Passing ProfileID instead of Profile* to clarify that profile should not be used for making any cal…

chrome/browser/notifications/message_center_notification_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/notifications/message_center_notification_manager.h"
 
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/prefs/pref_registry_simple.h"
 #include "base/prefs/pref_service.h"
@@ skipping 213 matching lines @@
     return false;
 
   RemoveProfileNotification(iter->second);
   message_center_->RemoveNotification(profile_notification_id,
                                       /* by_user */ false);
   return true;
 }
 
 std::set<std::string>
 MessageCenterNotificationManager::GetAllIdsByProfileAndSourceOrigin(
-    Profile* profile,
+    ProfileID profile_id,
     const GURL& source) {
   // The profile pointer can be weak, the instance may have been destroyed, so

[Peter Beverloo, 2015/05/21 11:28:48]

nit: You can now remove this comment.

[Deepak, 2015/05/21 14:01:07]

Done.

   // no profile method should be called inside this function.
 
   std::set<std::string> delegate_ids;
   for (const auto& pair : profile_notifications_) {
     const Notification& notification = pair.second->notification();
-    if (pair.second->profile() == profile &&
+    if (pair.second->profile() == profile_id &&
         notification.origin_url() == source) {
       delegate_ids.insert(notification.delegate_id());
     }
   }
 
   return delegate_ids;
 }
 
 std::set<std::string> MessageCenterNotificationManager::GetAllIdsByProfile(
-    Profile* profile) {
+    ProfileID profile_id) {
   // The profile pointer can be weak, the instance may have been destroyed, so

[Peter Beverloo, 2015/05/21 11:28:48]

nit: You can now remove this comment.

[Deepak, 2015/05/21 14:01:07]

Done.

   // no profile method should be called inside this function.
 
   std::set<std::string> delegate_ids;
   for (const auto& pair : profile_notifications_) {
-    if (pair.second->profile() == profile)
+    if (pair.second->profile() == profile_id)

[Peter Beverloo, 2015/05/21 11:28:48]

This is now a [Profile* == void*] comparison. Even if the bots were fine with
that, comparing a [profile*] to a [profile id] doesn't read well.

What about the following? It's more verbose, but more correct to read.

=========================
for (const auto& pair : profile_notifications_) {
  if (NotificationUIManager::GetProfileID(pair.second->profile()) == profile_id)
    delegate_ids.insert(pair.second->notification().delegate_id());
}
=========================

Dito on line 244.

[Deepak, 2015/05/21 14:01:07]

Done.

       delegate_ids.insert(pair.second->notification().delegate_id());
   }
 
   return delegate_ids;
 }
 
 bool MessageCenterNotificationManager::CancelAllBySourceOrigin(
     const GURL& source) {
   // Same pattern as CancelById, but more complicated than the above
   // because there may be multiple notifications from the same source.
@@ skipping 152 matching lines @@
        it != registry->enabled_extensions().end();
        ++it) {
     if ((*it->get()).permissions_data()->HasAPIPermission(
             extensions::APIPermission::ID::kNotificationProvider)) {
       extension_id = (*it->get()).id();
       return extension_id;
     }
   }
   return extension_id;
 }