Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1155403003: add asserts around results from requestLock (Closed)

Created:
5 years, 6 months ago by reed1
Modified:
5 years, 6 months ago
Reviewers:
scroggo
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

add asserts around results from requestLock and lockPixels, ensuring that true always means we have non-null pixels (and non-null colortable if that matches the colortype) BUG=491975 TBR= Committed: https://skia.googlesource.com/skia/+/f941a68126d8fe647eaea902c244c466568b7809

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -28 lines) Patch
M include/core/SkPixelRef.h View 1 3 chunks +6 lines, -2 lines 0 comments Download
M src/core/SkPixelRef.cpp View 1 2 5 chunks +38 lines, -26 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1155403003/1
5 years, 6 months ago (2015-05-29 15:46:51 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1155403003/40001
5 years, 6 months ago (2015-05-29 16:03:54 UTC) #4
reed1
ptal
5 years, 6 months ago (2015-05-29 16:04:36 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-05-29 16:37:35 UTC) #8
scroggo
lgtm
5 years, 6 months ago (2015-05-29 17:03:29 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1155403003/40001
5 years, 6 months ago (2015-05-29 18:38:39 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://skia.googlesource.com/skia/+/f941a68126d8fe647eaea902c244c466568b7809
5 years, 6 months ago (2015-05-29 18:39:22 UTC) #12
reed1
5 years, 6 months ago (2015-05-29 21:21:28 UTC) #13
Message was sent while issue was closed. 
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1159013006/ by reed@google.com.

The reason for reverting is: asserts in ui/gfx unittests (need to investigate
why)

[ RUN      ] RenderTextTest.SelectionKeepsLigatures
[14602:14602:0529/134016:16779526944:INFO:SkPixelRef.cpp(164)]
../../third_party/skia/src/core/SkPixelRef.cpp:164: failed assertion "pixels"
.

Powered by Google App Engine
This is Rietveld 408576698