Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Unified Diff: content/renderer/render_view_impl.cc

Issue 11554030: <webview>: Add name attribute (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Added tests Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index 40a87b64da5db54340f446553d22e6abd15386ef..c6f90434bc49f3bc0d3a82d8280b53f13c6e1fb9 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -935,6 +935,7 @@ bool RenderViewImpl::OnMessageReceived(const IPC::Message& message) {
IPC_MESSAGE_HANDLER(ViewMsg_PasteAndMatchStyle, OnPasteAndMatchStyle)
IPC_MESSAGE_HANDLER(ViewMsg_Replace, OnReplace)
IPC_MESSAGE_HANDLER(ViewMsg_Delete, OnDelete)
+ IPC_MESSAGE_HANDLER(ViewMsg_SetName, OnSetName)
IPC_MESSAGE_HANDLER(ViewMsg_SelectAll, OnSelectAll)
IPC_MESSAGE_HANDLER(ViewMsg_ReplaceAll, OnReplaceAll)
IPC_MESSAGE_HANDLER(ViewMsg_Unselect, OnUnselect)
@@ -1349,6 +1350,13 @@ void RenderViewImpl::OnDelete() {
webview()->focusedFrame()->executeCommand(WebString::fromUTF8("Delete"));
}
+void RenderViewImpl::OnSetName(const std::string& name) {
+ if (!webview())
+ return;
+
+ webview()->mainFrame()->setName(WebString::fromUTF8(name));
+}
+
void RenderViewImpl::OnSelectAll() {
if (!webview())
return;
@@ -2684,6 +2692,14 @@ void RenderViewImpl::willClose(WebFrame* frame) {
FOR_EACH_OBSERVER(RenderViewObserver, observers_, FrameWillClose(frame));
}
+void RenderViewImpl::didChangeName(WebFrame* frame,
+ const WebString& name) {
+ Send(new ViewHostMsg_UpdateFrameName(routing_id_,
+ frame->identifier(),
+ !frame->parent(),
+ UTF16ToUTF8(name)));
+}
+
void RenderViewImpl::loadURLExternally(
WebFrame* frame, const WebURLRequest& request,
WebNavigationPolicy policy) {

Powered by Google App Engine
This is Rietveld 408576698