<webview>: Add name attribute

content/browser/browser_plugin/browser_plugin_guest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/browser_plugin/browser_plugin_guest.h"
 
 #include <algorithm>
 
 #include "base/string_util.h"
 #include "content/browser/browser_plugin/browser_plugin_embedder.h"
@@ skipping 40 matching lines @@
 #if defined(OS_WIN)
       damage_buffer_size_(0),
       remote_damage_buffer_handle_(0),
 #endif
       damage_buffer_scale_factor_(1.0f),
       pending_update_counter_(0),
       guest_hang_timeout_(
           base::TimeDelta::FromMilliseconds(kHungRendererDelayMs)),
       focused_(params.focused),
       visible_(params.visible),
+      name_(params.name),
       auto_size_enabled_(params.auto_size_params.enable),
       max_auto_size_(params.auto_size_params.max_size),
       min_auto_size_(params.auto_size_params.min_size) {
   DCHECK(web_contents);
 }
 
 void BrowserPluginGuest::InstallHelper(
     content::RenderViewHost* render_view_host) {
   // |render_view_host| manages the ownership of this BrowserPluginGuestHelper.
   new BrowserPluginGuestHelper(this, render_view_host);
 
   notification_registrar_.Add(
       this, content::NOTIFICATION_RESOURCE_RECEIVED_REDIRECT,
       content::Source<content::WebContents>(web_contents()));
 }
 
+void BrowserPluginGuest::SetName(const std::string& name) {
+  if (name == name_)
+    return;
+  name_ = name;
+  web_contents()->GetRenderViewHost()->Send(new ViewMsg_SetName(
+      web_contents()->GetRenderViewHost()->GetRoutingID(),
+      name));

[Charlie Reis, 2012/12/13 01:11:42]

nit: This last arg can go on previous line, which would be easier to read. 
(Only function signatures need each arg on a separate line.)

[Fady Samuel, 2012/12/13 17:46:45]

Done.

+}
+
+void BrowserPluginGuest::UpdateFrameName(int frame_id,
+                                         bool is_top_level,
+                                         const std::string& name) {
+  if (!is_top_level)
+    return;
+
+  name_ = name;
+  SendMessageToEmbedder(new BrowserPluginMsg_UpdatedName(
+      embedder_routing_id(),
+      instance_id_,
+      name));
+}
+
 BrowserPluginGuest::~BrowserPluginGuest() {
 }
 
 // static
 BrowserPluginGuest* BrowserPluginGuest::Create(
     int instance_id,
     WebContentsImpl* web_contents,
     const BrowserPluginHostMsg_CreateGuest_Params& params) {
   RecordAction(UserMetricsAction("BrowserPlugin.Guest.Create"));
   if (factory_) {
@@ skipping 453 matching lines @@
                                                        cursor));
 }
 
 void BrowserPluginGuest::DidStartProvisionalLoadForFrame(
     int64 frame_id,
     int64 parent_frame_id,
     bool is_main_frame,
     const GURL& validated_url,
     bool is_error_page,
     RenderViewHost* render_view_host) {
+  // Reset the guest name if we are loading a new main frame.
+  UpdateFrameName(frame_id, is_main_frame, "");

[Charlie Reis, 2012/12/13 01:11:42]

Though I wish the web platform worked this way, it's not true.  A window's name
sticks around after navigations.  The name applies to the "browsing context,"
not the document.

[Fady Samuel, 2012/12/13 17:46:45]

Removed, thanks. 

   // Inform the embedder of the loadStart.
   SendMessageToEmbedder(
       new BrowserPluginMsg_LoadStart(embedder_routing_id(),
                                      instance_id(),
                                      validated_url,
                                      is_main_frame));
 }
 
 void BrowserPluginGuest::DidFailProvisionalLoad(
     int64 frame_id,
@@ skipping 59 matching lines @@
   Send(new ViewMsg_SetFocus(routing_id(), focused_));
   bool embedder_visible =
       embedder_web_contents_->GetBrowserPluginEmbedder()->visible();
   SetVisibility(embedder_visible, visible());
   if (auto_size_enabled_) {
     web_contents()->GetRenderViewHost()->EnableAutoResize(
         min_auto_size_, max_auto_size_);
   } else {
     web_contents()->GetRenderViewHost()->DisableAutoResize(damage_view_size_);
   }
+
+  web_contents()->GetRenderViewHost()->Send(new ViewMsg_SetName(

[Charlie Reis, 2012/12/13 01:11:42]

We should cache the RVH in a local variable, since this virtual method is called
at least 3 times here.

[Fady Samuel, 2012/12/13 17:46:45]

Done.

+      web_contents()->GetRenderViewHost()->GetRoutingID(),
+      name_));
 }
 
 void BrowserPluginGuest::RenderViewGone(base::TerminationStatus status) {
   int process_id = web_contents()->GetRenderProcessHost()->GetID();
   SendMessageToEmbedder(new BrowserPluginMsg_GuestGone(embedder_routing_id(),
                                                        instance_id(),
                                                        process_id,
                                                        status));
   IDMap<RenderViewHost>::const_iterator iter(&pending_updates_);
   while (!iter.IsAtEnd()) {
@@ skipping 14 matching lines @@
     default:
       break;
   }
 }
 
 void BrowserPluginGuest::SendMessageToEmbedder(IPC::Message* msg) {
   embedder_web_contents_->Send(msg);
 }
 
 }  // namespace content