<webview>: Add name attribute

chrome/renderer/resources/extensions/web_view.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Shim that simulates a <webview> tag via Mutation Observers.
 //
 // The actual tag is implemented via the browser plugin. The internals of this
 // are hidden via Shadow DOM.
 
 var watchForTag = require("tagWatcher").watchForTag;
 
-var WEB_VIEW_ATTRIBUTES = ['src', 'partition'];
+var WEB_VIEW_ATTRIBUTES = ['name', 'src', 'partition'];
 
 // All exposed api methods for <webview>, these are forwarded to the browser
 // plugin.
 var WEB_VIEW_API_METHODS = [
   'back',
   'canGoBack',
   'canGoForward',
   'forward',
   'getProcessId',
   'go',
@@ skipping 95 matching lines @@
  */
 WebView.prototype.handleMutation_ = function(mutation) {
   this.objectNode_[mutation.attributeName] =
       this.node_.getAttribute(mutation.attributeName);
 };
 
 /**
  * @private
  */
 WebView.prototype.handleObjectMutation_ = function(mutation) {
-  this.node_.setAttribute(mutation.attributeName,
-      this.objectNode_.getAttribute(mutation.attributeName));
+  if (!this.objectNode_.hasAttribute(mutation.attributeName)) {

[Charlie Reis, 2012/12/13 01:11:42]

I'm not entirely sure which type of attribute change this is preventing.  (Is it
coming from within the BrowserPlugin or from JS code?)  Perhaps a comment with
an example of why we need this would help?

[Fady Samuel, 2012/12/13 17:46:45]

Done.

+    this.node_.removeAttribute(mutation.attributeName);
+  } else {
+    this.node_.setAttribute(mutation.attributeName,
+        this.objectNode_.getAttribute(mutation.attributeName));
+  }
 };
 
 /**
  * @private
  */
 WebView.prototype.setupEvent_ = function(eventname, attribs) {
   var node = this.node_;
   this.objectNode_.addEventListener('-internal-' + eventname, function(e) {
     var evt = new Event(eventname);
     var detail = e.detail ? JSON.parse(e.detail) : {};
     attribs.forEach(function(attribName) {
       evt[attribName] = detail[attribName];
     });
     node.dispatchEvent(evt);
   });
 }