Object.observe: Make array length and other magic data properties work correctly.

Object.observe: Make array length and other magic data properties work correctly.

Also, disable TestFastElementsLength test for now, since it flakes on buildbots for yet unknown reasons.

R=mstarzinger@chromium.org
BUG=v8:2409
Committed: http://code.google.com/p/v8/source/detail?r=13213

[Michael Starzinger, 2012-12-12 15:34:05]

LGTM (with comments for the predicate in LookupResult). Adding Sven.

https://codereview.chromium.org/11554019/diff/1/src/property.h
File src/property.h (right):

https://codereview.chromium.org/11554019/diff/1/src/property.h#newcode320
src/property.h:320: return GetCallbackObject()->IsForeign();
I think AccessorInfo callbacks should also return true here, they also look like
data properties to JavaScript.

https://codereview.chromium.org/11554019/diff/1/src/property.h#newcode321
src/property.h:321: default:
I think Sven has to say something about this default case.

https://codereview.chromium.org/11554019/diff/1/src/v8natives.js
File src/v8natives.js (right):

https://codereview.chromium.org/11554019/diff/1/src/v8natives.js#newcode896
src/v8natives.js:896: // TODO(mstarzinger): This hack should be removed once we
have addressed the
Interesting, TODO with my name popping out of thin air. Strange. :)

[rossberg, 2012-12-12 15:41:10]

https://codereview.chromium.org/11554019/diff/1/src/property.h
File src/property.h (right):

https://codereview.chromium.org/11554019/diff/1/src/property.h#newcode320
src/property.h:320: return GetCallbackObject()->IsForeign();
On 2012/12/12 15:34:05, Michael Starzinger wrote:
> I think AccessorInfo callbacks should also return true here, they also look
like
> data properties to JavaScript.

Done.

https://codereview.chromium.org/11554019/diff/1/src/property.h#newcode321
src/property.h:321: default:
On 2012/12/12 15:34:05, Michael Starzinger wrote:
> I think Sven has to say something about this default case.

Unfolded default (also in GetLazyValue below).