Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 1155393003: Update check in KillingRendererClearsDescendantProxies test. (Closed)

Created:
5 years, 7 months ago by Charlie Reis
Modified:
5 years, 7 months ago
Reviewers:
ncarter (slow)
CC:
chromium-reviews, darin-cc_chromium.org, jam, Avi (use Gerrit), site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update check in KillingRendererClearsDescendantProxies test. The SiteInstance will not go away once it is stored in session history, so make sure its frames and proxies are gone directly. BUG=464014 TEST=SitePerProcessBrowserTest.KillingRendererClearsDescendantProxies Committed: https://crrev.com/ceaabfd57219e21bd67f62740f3557032b92b17b Cr-Commit-Position: refs/heads/master@{#331636}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix suggestion #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M content/browser/site_per_process_browsertest.cc View 1 3 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Charlie Reis
Nick, can you take a look? This test starts to fail once I fix the ...
5 years, 7 months ago (2015-05-27 17:26:12 UTC) #2
ncarter (slow)
https://codereview.chromium.org/1155393003/diff/1/content/browser/site_per_process_browsertest.cc File content/browser/site_per_process_browsertest.cc (right): https://codereview.chromium.org/1155393003/diff/1/content/browser/site_per_process_browsertest.cc#newcode1074 content/browser/site_per_process_browsertest.cc:1074: root->render_manager()->GetRenderFrameProxyHost(site_instance_c.get())); This EXPECT (and the one on line 1050) ...
5 years, 7 months ago (2015-05-27 19:44:26 UTC) #3
ncarter (slow)
lgtm
5 years, 7 months ago (2015-05-27 19:46:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1155393003/20001
5 years, 7 months ago (2015-05-27 19:49:17 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-27 20:26:53 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-27 20:27:46 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ceaabfd57219e21bd67f62740f3557032b92b17b
Cr-Commit-Position: refs/heads/master@{#331636}

Powered by Google App Engine
This is Rietveld 408576698