Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1155383003: X87: VectorICs: allocating slots for store ics in ast nodes. (Closed)

Created:
5 years, 6 months ago by chunyang.dai
Modified:
5 years, 6 months ago
Reviewers:
Weiliang
CC:
v8-dev, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: VectorICs: allocating slots for store ics in ast nodes. port 5450fc07ba07615a70f5ed8379dc23c3275d6fe3 (r18659) original commit message: Also adapt code generation to pass the slot to the store/keyed-store ic. AST nodes ObjectLiteral, Assignment, ForEach, Call and CountOperation now include one or more feedback vector ic slot ids. BUG= Committed: https://crrev.com/f1cc4ed2b28696f940617a0016e781237d734c49 Cr-Commit-Position: refs/heads/master@{#28718}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -24 lines) Patch
M src/x87/full-codegen-x87.cc View 27 chunks +83 lines, -24 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL
5 years, 6 months ago (2015-06-01 06:15:23 UTC) #2
Weiliang
lgtm
5 years, 6 months ago (2015-06-01 08:23:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1155383003/1
5 years, 6 months ago (2015-06-01 08:24:07 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-01 09:04:46 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-01 09:04:58 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f1cc4ed2b28696f940617a0016e781237d734c49
Cr-Commit-Position: refs/heads/master@{#28718}

Powered by Google App Engine
This is Rietveld 408576698