Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1213)

Issue 1155383002: Use SkTArray instead of SkSTArray in movable. (Closed)

Created:
5 years, 7 months ago by bungeman-skia
Modified:
5 years, 7 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Use SkTArray instead of SkSTArray in movable. SkTArray is trivially movable, but SkSTArray is not, since it may contain an internal pointer. FontFileInfo is supposed to be trivially movable but currently isn't due to containing an SkSTArray. Removing this particular optimization should not affect performance much as this type is only used for parsing and does not allocate any memory unless a variation axis is actually specified. Committed: https://skia.googlesource.com/skia/+/a9f1db7902227143f97e4e29c1eefcd690f6aced

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/ports/SkFontConfigParser_android.h View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 10 (4 generated)
bungeman-skia
https://codereview.chromium.org/1155383002/diff/1/src/ports/SkFontConfigParser_android.h File src/ports/SkFontConfigParser_android.h (right): https://codereview.chromium.org/1155383002/diff/1/src/ports/SkFontConfigParser_android.h#newcode79 src/ports/SkFontConfigParser_android.h:79: SkTArray<Axis, true> fAxes; Note comment above that FontFileInfo must ...
5 years, 7 months ago (2015-05-27 14:43:28 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1155383002/1
5 years, 7 months ago (2015-05-27 14:44:52 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-27 14:50:23 UTC) #6
reed1
lgtm
5 years, 7 months ago (2015-05-27 20:08:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1155383002/1
5 years, 7 months ago (2015-05-27 20:09:38 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-27 20:10:06 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/a9f1db7902227143f97e4e29c1eefcd690f6aced

Powered by Google App Engine
This is Rietveld 408576698