Add the RSS page action extension....

Add the RSS page action extension.

BUG=12060
TEST=Enable this extension, browse to a page with a Feed and an RSS icon should show up in the Omnibox. Clicking it brings you to a subscribe page. No feed preview is displayed.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=16425

[Finnur, 2009-05-19 20:34:38]

First cut at the RSS page action extension.

[Aaron Boodman, 2009-05-19 21:06:53]

Few nits.

http://codereview.chromium.org/115536/diff/1008/1014
File chrome/test/data/extensions/samples/subscribe_page_action/manifest.json
(right):

http://codereview.chromium.org/115536/diff/1008/1014#newcode2
Line 2: "id": "5C38AE132BBF497CBEEE28F202A82DED2DAB6B07",
Please remove the ID.

http://codereview.chromium.org/115536/diff/1008/1014#newcode24
Line 24: "type": "tab"
Do we still use the "type" property?

http://codereview.chromium.org/115536/diff/1008/1011
File chrome/test/data/extensions/samples/subscribe_page_action/subscribe.html
(right):

http://codereview.chromium.org/115536/diff/1008/1011#newcode3
Line 3: <title>Subscribe to feed</title>
Nit: can you unindent this title tag?

http://codereview.chromium.org/115536/diff/1008/1011#newcode7
Line 7: var combobox = document.getElementById("readers");
Nit: HTML doesn't have a combobox. Can you name this "select"?

http://codereview.chromium.org/115536/diff/1008/1011#newcode8
Line 8: var feed_url = document.location.search.substring(1);
Nit: maybe add a little inline comment here that you're stripping the question
mark character.

http://codereview.chromium.org/115536/diff/1008/1011#newcode21
Line 21: <input name="subscribe" type="button" value="Subscribe Now"
Use a <button> tag instead. Also, there's no need for the name property I don't
think.

http://codereview.chromium.org/115536/diff/1008/1011#newcode22
Line 22: onclick="javascript:navigate();">
The "javascript:" here does nothing. It can be removed.

[Finnur, 2009-05-19 22:21:41]

Uploaded. As discussed offline we want to keep the 'type' property in the
manifest for now.

[Aaron Boodman, 2009-05-19 22:41:26]

LGTM!