Throw DOMException when invoked Document::execCommand on non-{X,}HTML documents

Source/core/dom/Document.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  *           (C) 2006 Alexey Proskuryakov (ap@webkit.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All rights reserved.
  * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved.
  * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
  * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved.
@@ skipping 4227 matching lines @@
 static Editor::Command command(Document* document, const String& commandName)
 {
     LocalFrame* frame = document->frame();
     if (!frame || frame->document() != document)
         return Editor::Command();
 
     document->updateLayoutTreeIfNeeded();
     return frame->editor().command(commandName, CommandFromDOM);
 }
 
-bool Document::execCommand(const String& commandName, bool, const String& value)
+bool Document::execCommand(const String& commandName, bool, const String& value, ExceptionState& exceptionState)
 {
+    if (!isHTMLDocument() && !isXHTMLDocument()) {
+        exceptionState.throwDOMException(InvalidStateError, "execCommand is only supported on HTML documents.");
+        return false;
+    }
+
     // We don't allow recursive |execCommand()| to protect against attack code.
     // Recursive call of |execCommand()| could be happened by moving iframe
     // with script triggered by insertion, e.g. <iframe src="javascript:...">
     // <iframe onload="...">. This usage is valid as of the specification
     // although, it isn't common use case, rather it is used as attack code.
     static bool inExecCommand = false;
     if (inExecCommand) {
         String message = "We don't execute document.execCommand() this time, because it is called recursively.";
         addConsoleMessage(ConsoleMessage::create(JSMessageSource, WarningMessageLevel, message));
         return false;
     }
     TemporaryChange<bool> executeScope(inExecCommand, true);
 
     // Postpone DOM mutation events, which can execute scripts and change
     // DOM tree against implementation assumption.
     EventQueueScope eventQueueScope;
     Editor::Command editorCommand = command(this, commandName);
     Platform::current()->histogramSparse("WebCore.Document.execCommand", editorCommand.idForHistogram());
     return editorCommand.execute(value);
 }
 
-bool Document::queryCommandEnabled(const String& commandName)
+bool Document::queryCommandEnabled(const String& commandName, ExceptionState& exceptionState)
 {
+    if (!isHTMLDocument() && !isXHTMLDocument()) {
+        exceptionState.throwDOMException(InvalidStateError, "queryCommandEnabled is only supported on HTML documents.");
+        return false;
+    }
+
     return command(this, commandName).isEnabled();
 }
 
-bool Document::queryCommandIndeterm(const String& commandName)
+bool Document::queryCommandIndeterm(const String& commandName, ExceptionState& exceptionState)
 {
+    if (!isHTMLDocument() && !isXHTMLDocument()) {
+        exceptionState.throwDOMException(InvalidStateError, "queryCommandIndeterm is only supported on HTML documents.");
+        return false;
+    }
+
     return command(this, commandName).state() == MixedTriState;
 }
 
-bool Document::queryCommandState(const String& commandName)
+bool Document::queryCommandState(const String& commandName, ExceptionState& exceptionState)
 {
+    if (!isHTMLDocument() && !isXHTMLDocument()) {
+        exceptionState.throwDOMException(InvalidStateError, "queryCommandState is only supported on HTML documents.");
+        return false;
+    }
+
     return command(this, commandName).state() == TrueTriState;
 }
 
-bool Document::queryCommandSupported(const String& commandName)
+bool Document::queryCommandSupported(const String& commandName, ExceptionState& exceptionState)
 {
+    if (!isHTMLDocument() && !isXHTMLDocument()) {
+        exceptionState.throwDOMException(InvalidStateError, "queryCommandSupported is only supported on HTML documents.");
+        return false;
+    }
+
     return command(this, commandName).isSupported();
 }
 
-String Document::queryCommandValue(const String& commandName)
+String Document::queryCommandValue(const String& commandName, ExceptionState& exceptionState)
 {
+    if (!isHTMLDocument() && !isXHTMLDocument()) {
+        exceptionState.throwDOMException(InvalidStateError, "queryCommandValue is only supported on HTML documents.");
+        return "";
+    }
+
     return command(this, commandName).value();
 }
 
 KURL Document::openSearchDescriptionURL()
 {
     static const char openSearchMIMEType[] = "application/opensearchdescription+xml";
     static const char openSearchRelation[] = "search";
 
     // FIXME: Why do only top-level frames have openSearchDescriptionURLs?
     if (!frame() || frame()->tree().parent())
@@ skipping 1377 matching lines @@
 #ifndef NDEBUG
 using namespace blink;
 void showLiveDocumentInstances()
 {
     WeakDocumentSet& set = liveDocumentSet();
     fprintf(stderr, "There are %u documents currently alive:\n", set.size());
     for (Document* document : set)
         fprintf(stderr, "- Document %p URL: %s\n", document, document->url().string().utf8().data());
 }
 #endif