Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Issue 1155333003: Revert of Revert of Converted some extension browser tests into using event pages (Closed)

Created:
5 years, 6 months ago by oystein (OOO til 10th of July)
Modified:
5 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Revert of Converted some extension browser tests into using event pages (patchset #1 id:1 of https://codereview.chromium.org/1159593004/) Reason for revert: Reverting the revert, the test failure was actually fixed by this revert: https://codereview.chromium.org/1159353003 Original issue's description: > Revert of Converted some extension browser tests into using event pages (patchset #1 id:60001 of https://codereview.chromium.org/1108133002/) > > Reason for revert: > browser_tests ExtensionApiTest.AutotestPrivate failed on MSan bot > > BUG=494815 > > Original issue's description: > > Converted some extension browser tests into using event pages, to fix some timeout issues when background pages have their DOM timers throttled. > > > > R=kalman > > BUG= > > > > Committed: https://crrev.com/1dc63af0201f5429133b814be52aab24f8d71f16 > > Cr-Commit-Position: refs/heads/master@{#332059} > > TBR=kalman@chromium.org,oysteine@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG= > > Committed: https://crrev.com/cda8c938f06f9955ac895099d05a9db3b61f3ab5 > Cr-Commit-Position: refs/heads/master@{#332159} TBR=kalman@chromium.org,zhaoqin@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=494815 Committed: https://crrev.com/542018467975906306ea2ba5355996011f5f947f Cr-Commit-Position: refs/heads/master@{#332519}

Patch Set 1 #

Messages

Total messages: 4 (0 generated)
oystein (OOO til 10th of July)
Created Revert of Revert of Converted some extension browser tests into using event pages
5 years, 6 months ago (2015-06-03 01:06:52 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1155333003/1
5 years, 6 months ago (2015-06-03 01:08:34 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-03 01:11:38 UTC) #3
commit-bot: I haz the power
5 years, 6 months ago (2015-06-03 01:12:28 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/542018467975906306ea2ba5355996011f5f947f
Cr-Commit-Position: refs/heads/master@{#332519}

Powered by Google App Engine
This is Rietveld 408576698