Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 1155313008: [turbofan] First steps towards optimizing for-in loops. (Closed)

Created:
5 years, 6 months ago by Benedikt Meurer
Modified:
5 years, 6 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] First steps towards optimizing for-in loops. This is basically a port of the majority of optimizations that are applied to for-in in full codegen. But it is not done during graph building, but instead during typed lowering, which way less adhoc than what the other compilers do. Committed: https://crrev.com/017faaf451a43b13b0e2938a027b68a23d5773e4 Cr-Commit-Position: refs/heads/master@{#28726}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+326 lines, -2 lines) Patch
M src/compiler/access-builder.h View 1 chunk +12 lines, -0 lines 0 comments Download
M src/compiler/access-builder.cc View 1 chunk +28 lines, -0 lines 0 comments Download
M src/compiler/graph.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/compiler/js-graph.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-graph.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/js-typed-lowering.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 2 chunks +270 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Benedikt Meurer
Hey Jaro, This is the port of the for-in stuff to typed lowering. It's pretty ...
5 years, 6 months ago (2015-06-01 10:29:28 UTC) #2
Jarin
lgtm
5 years, 6 months ago (2015-06-01 11:24:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1155313008/1
5 years, 6 months ago (2015-06-01 11:37:57 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-01 11:41:24 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-01 11:41:36 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/017faaf451a43b13b0e2938a027b68a23d5773e4
Cr-Commit-Position: refs/heads/master@{#28726}

Powered by Google App Engine
This is Rietveld 408576698