Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Issue 1155313002: Rearrange the XHR interfaces to match the spec order (Closed)

Created:
5 years, 7 months ago by philipj_slow
Modified:
5 years, 7 months ago
CC:
blink-reviews, vivekg, tyoshino+watch_chromium.org, arv+blink, Inactive, vivekg_samsung
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Rearrange the XHR interfaces to match the spec order https://xhr.spec.whatwg.org/#interface-xmlhttprequest To make reviewing easier, this commit only changes the order of lines and adds comments. Actual spec sync will be done separately. The order of the generated code changes, but there are no actual changes. BUG=460722 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195976

Patch Set 1 #

Total comments: 2

Patch Set 2 : add spec link #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -24 lines) Patch
M Source/core/xmlhttprequest/XMLHttpRequest.idl View 1 chunk +12 lines, -21 lines 0 comments Download
M Source/core/xmlhttprequest/XMLHttpRequestEventTarget.idl View 1 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
philipj_slow
PTAL
5 years, 7 months ago (2015-05-26 22:29:24 UTC) #2
vivekg
LGTM Although I am afraid about maintaining the same order when other developers start modifying ...
5 years, 7 months ago (2015-05-27 00:39:22 UTC) #4
tyoshino (SeeGerritForStatus)
lgtm once vivekg_'s comment is addressed.
5 years, 7 months ago (2015-05-27 05:04:38 UTC) #5
Jens Widell
LGTM On 2015/05/27 00:39:22, vivekg_ wrote: > Although I am afraid about maintaining the same ...
5 years, 7 months ago (2015-05-27 07:00:30 UTC) #6
philipj_slow
https://codereview.chromium.org/1155313002/diff/1/Source/core/xmlhttprequest/XMLHttpRequestEventTarget.idl File Source/core/xmlhttprequest/XMLHttpRequestEventTarget.idl (right): https://codereview.chromium.org/1155313002/diff/1/Source/core/xmlhttprequest/XMLHttpRequestEventTarget.idl#newcode27 Source/core/xmlhttprequest/XMLHttpRequestEventTarget.idl:27: [ On 2015/05/27 00:39:22, vivekg_ wrote: > nit: Can ...
5 years, 7 months ago (2015-05-27 08:47:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1155313002/20001
5 years, 7 months ago (2015-05-27 08:48:23 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-05-27 12:13:03 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195976

Powered by Google App Engine
This is Rietveld 408576698