Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issue 11553041: Remove pyautolib dependency (Closed)

Created:
8 years ago by nkang
Modified:
8 years ago
CC:
chromium-reviews
Visibility:
Public.

Description

Removed 'pyautolib' dependencies from install_test and removed some common code from run_install_test.py. Also, modified util.py and copied DoesUrlExist to it, so install_test doesn't have to depend on 'pyautolib.pyauto_utils'. BUG=163708, 163718 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173176

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -133 lines) Patch
M install_test/install_test.py View 5 chunks +6 lines, -41 lines 2 comments Download
M install_test/run_install_tests.py View 4 chunks +7 lines, -92 lines 0 comments Download
M pylib/common/util.py View 2 chunks +26 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
nkang
Removed all dependencies on 'pyautolib' from install_test and removed some common code from run_install_test.py, which ...
8 years ago (2012-12-13 00:55:17 UTC) #1
kkania
lgtm, but you need to get a review from an owner of pylib
8 years ago (2012-12-13 18:42:01 UTC) #2
nkang1
Added Pawel Hajdan for owner's review.
8 years ago (2012-12-13 19:18:12 UTC) #3
Paweł Hajdan Jr.
https://codereview.chromium.org/11553041/diff/1/install_test/install_test.py File install_test/install_test.py (left): https://codereview.chromium.org/11553041/diff/1/install_test/install_test.py#oldcode157 install_test/install_test.py:157: options.append('--installerdata="%s"' % master_pref) What's the problem with quotes here?
8 years ago (2012-12-13 19:28:01 UTC) #4
nkang1
Addressed the comment made by Paweł. https://codereview.chromium.org/11553041/diff/1/install_test/install_test.py File install_test/install_test.py (left): https://codereview.chromium.org/11553041/diff/1/install_test/install_test.py#oldcode157 install_test/install_test.py:157: options.append('--installerdata="%s"' % master_pref) ...
8 years ago (2012-12-13 19:45:59 UTC) #5
Paweł Hajdan Jr.
LGTM
8 years ago (2012-12-14 16:45:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nkang@chromium.org/11553041/1
8 years ago (2012-12-14 18:31:33 UTC) #7
commit-bot: I haz the power
8 years ago (2012-12-14 18:35:06 UTC) #8
Message was sent while issue was closed.
Change committed as 173176

Powered by Google App Engine
This is Rietveld 408576698