Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 1155303007: Remove SK_ANDROID_FREETYPE_HAS_MM from build. (Closed)

Created:
5 years, 6 months ago by bungeman-skia
Modified:
5 years, 6 months ago
Reviewers:
djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove SK_ANDROID_FREETYPE_HAS_MM from build. This flag is now no longer used now that GX variations now seem to have landed for good. Committed: https://skia.googlesource.com/skia/+/f3b8f10f220d649d28a559f0aa384c1fc32d8140

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M gyp/freetype.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
bungeman-skia
This is a follow up to https://codereview.chromium.org/1143133006/ now that it looks like it will stick.
5 years, 6 months ago (2015-06-03 21:52:48 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1155303007/1
5 years, 6 months ago (2015-06-04 01:41:19 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-04 11:04:59 UTC) #6
djsollen
lgtm
5 years, 6 months ago (2015-06-04 12:07:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1155303007/1
5 years, 6 months ago (2015-06-04 14:38:14 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-06-04 14:38:59 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/f3b8f10f220d649d28a559f0aa384c1fc32d8140

Powered by Google App Engine
This is Rietveld 408576698