Issue 1155303005: Fix logic in RenderPadding.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1155303005: Fix logic in RenderPadding. (Closed)

Created:
5 years, 6 months ago by Hixie

Modified:
5 years, 6 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Fix logic in RenderPadding. Previously, we were not adjusting the minimum width, so we ended up offsetting the child but not shrinking it, when the parent expected the child to be exactly fit to its dimensions. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/515a3851e5d2de2c78adf82e34aadc71d500cff2

Patch Set 1 #

Total comments: 1

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+47 lines, -7 lines)			Patch
M	sky/sdk/lib/framework/rendering/block.dart	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	sky/sdk/lib/framework/rendering/box.dart	View	3 chunks	+9 lines, -5 lines	1 comment	Download
A	sky/tests/raw/box_layout.dart	View	1 chunk	+24 lines, -0 lines	0 comments	Download
A +	sky/tests/raw/box_layout-expected.txt	View	1 chunk	+7 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

abarth-chromium

lgtm https://codereview.chromium.org/1155303005/diff/1/sky/sdk/lib/framework/rendering/box.dart File sky/sdk/lib/framework/rendering/box.dart (right): https://codereview.chromium.org/1155303005/diff/1/sky/sdk/lib/framework/rendering/box.dart#newcode45 sky/sdk/lib/framework/rendering/box.dart:45: var vertical = edges.top + edges.bottom; s/var/double/

5 years, 6 months ago (2015-06-03 17:22:33 UTC) #2

Hixie

5 years, 6 months ago (2015-06-03 17:25:10 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
515a3851e5d2de2c78adf82e34aadc71d500cff2 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages