Add client certificates to HttpsServer and HttpClient.

runtime/bin/secure_socket.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "bin/secure_socket.h"
 
 #include <errno.h>
 #include <fcntl.h>
 #include <sys/stat.h>
 #include <stdio.h>
@@ skipping 394 matching lines @@
                         bool is_server,
                         const char* certificate_name,
                         bool request_client_certificate,
                         bool require_client_certificate,
                         bool send_client_certificate) {
   is_server_ = is_server;
   if (in_handshake_) {
     ThrowException("Connect called while already in handshake state.");
   }
 
+  if (!is_server && certificate_name != NULL) {
+    client_certificate_name_ = strdup(certificate_name);
+  }
+
   filter_ = SSL_ImportFD(NULL, filter_);
   if (filter_ == NULL) {
     ThrowPRException("Failed SSL_ImportFD call");
   }
 
   SECStatus status;
   if (is_server) {
     PK11_SetPasswordFunc(PasswordCallback);
     CERTCertDBHandle* certificate_database = CERT_GetDefaultCertDB();
     if (certificate_database == NULL) {
@@ skipping 49 matching lines @@
     // TODO(7230): Reenable session cache, without breaking client connections.
     status = SSL_OptionSet(filter_, SSL_NO_CACHE, PR_TRUE);
     if (status != SECSuccess) {
       ThrowPRException("Failed SSL_OptionSet(NO_CACHE) call");
     }
 
     if (send_client_certificate) {
       status = SSL_GetClientAuthDataHook(
           filter_,
           NSS_GetClientAuthData,
-          static_cast<void*>(const_cast<char*>(certificate_name)));
+          static_cast<void*>(client_certificate_name_));
       if (status != SECSuccess) {
         ThrowPRException("Failed SSL_GetClientAuthDataHook call");
       }
     }
   }
 
   // Install bad certificate callback, and pass 'this' to it if it is called.
   status = SSL_BadCertHook(filter_,
                            BadCertificateCallback,
                            static_cast<void*>(this));
@@ skipping 50 matching lines @@
   for (int i = 0; i < kNumBuffers; ++i) {
     Dart_DeletePersistentHandle(dart_buffer_objects_[i]);
     delete[] buffers_[i];
   }
   Dart_DeletePersistentHandle(string_start_);
   Dart_DeletePersistentHandle(string_length_);
   Dart_DeletePersistentHandle(handshake_complete_);
   if (bad_certificate_callback_ != NULL) {
     Dart_DeletePersistentHandle(bad_certificate_callback_);
   }
+  free(client_certificate_name_);
 
   PR_Close(filter_);
 }
 
 
 intptr_t SSLFilter::ProcessBuffer(int buffer_index) {
   Dart_Handle buffer_object = dart_buffer_objects_[buffer_index];
   Dart_Handle start_object = ThrowIfError(
       Dart_GetField(buffer_object, string_start_));
   Dart_Handle length_object = ThrowIfError(
@@ skipping 83 matching lines @@
         if (PR_WOULD_BLOCK_ERROR != pr_error) {
           ThrowPRException("Error reading plaintext from SSLFilter");
         }
         bytes_processed = 0;
       }
       break;
     }
   }
   return bytes_processed;
 }