Move path-manipulation code from io.dart into path.dart.

utils/tests/pub/path/path_windows_test.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library path_test;
 
 import 'dart:io' as io;
 
 import '../../../../pkg/unittest/lib/unittest.dart';
 import '../../../pub/path.dart' as path;
@@ skipping 17 matching lines @@
   test('extension', () {
     expect(builder.extension(''), '');
     expect(builder.extension('foo.dart'), '.dart');
     expect(builder.extension('foo.dart.js'), '.js');
     expect(builder.extension(r'a.b\c'), '');
     expect(builder.extension('a.b/c.d'), '.d');
     expect(builder.extension(r'~\.bashrc'), '');
     expect(builder.extension(r'a.b/c'), r'');
   });
 
+  test('rootOf', () {
+    expect(builder.rootOf(''), null);
+    expect(builder.rootOf('a'), null);
+    expect(builder.rootOf(r'a\b'), null);
+    expect(builder.rootOf(r'C:\a\c'), 'C:\\');

[Bob Nystrom, 2012/12/12 00:01:20]

Can you use raw strings for these? Here and below.

[nweiz, 2012/12/12 00:50:37]

It screws with my editor to have a string ending with "\", even if it's a raw
string :-/. I can make them raw strings if you really want, but it'll make my
life tougher for relatively little gain.

[Bob Nystrom, 2012/12/12 01:02:13]

It screws up my editor too (I need to fix the sublime bundle) but I do really
want raw strings here. I tripped over reading these a bunch of times.

[nweiz, 2012/12/12 02:45:57]

Done.

+    expect(builder.rootOf('C:\\'), 'C:\\');
+    expect(builder.rootOf('C:/'), 'C:/');
+
+    // TODO(nweiz): enable this once issue 7323 is fixed.
+    // expect(builder.rootOf(r'\\server\a\b'), '\\\\server\\');
+  });
+
+  test('dirname', () {
+    expect(builder.dirname(r''), '.');
+    expect(builder.dirname(r'a'), '.');
+    expect(builder.dirname(r'a\b'), 'a');
+    expect(builder.dirname(r'a\b\c'), r'a\b');
+    expect(builder.dirname(r'a\b.c'), 'a');
+    expect(builder.dirname('a\\'), 'a');
+    expect(builder.dirname('a/'), 'a');
+    expect(builder.dirname(r'a\.'), 'a');
+    expect(builder.dirname(r'a\b/c'), r'a\b');
+  });
+
   test('basename', () {
     expect(builder.basename(r''), '');
     expect(builder.basename(r'a'), 'a');
     expect(builder.basename(r'a\b'), 'b');
     expect(builder.basename(r'a\b\c'), 'c');
     expect(builder.basename(r'a\b.c'), 'b.c');
     expect(builder.basename(r'a\'), '');
     expect(builder.basename(r'a/'), '');
     expect(builder.basename(r'a\.'), '.');
     expect(builder.basename(r'a\b/c'), r'c');
@@ skipping 68 matching lines @@
       expect(builder.join('a/', 'b'), r'a/b');
       expect(builder.join('a', '/b'), 'a/b');
       expect(builder.join('a', r'\b'), r'a\b');
     });
 
     test('ignores parts before an absolute path', () {
       expect(builder.join('a', '/b', '/c', 'd'), r'a/b/c\d');
       expect(builder.join('a', r'c:\b', 'c', 'd'), r'c:\b\c\d');
       expect(builder.join('a', r'\\b', r'\\c', 'd'), r'\\c\d');
     });
+
+    test('ignores trailing nulls', () {
+      expect(builder.join('a', null), equals('a'));
+      expect(builder.join('a', 'b', 'c', null, null), equals(r'a\b\c'));
+    });
+
+    test('disallows intermediate nulls', () {
+      expect(() => builder.join('a', null, 'b'), throwsArgumentError);
+      expect(() => builder.join(null, 'a'), throwsArgumentError);
+    });
+  });
+
+  group('split', () {
+    test('simple cases', () {
+      expect(builder.split('foo'), equals(['foo']));
+      expect(builder.split(r'foo\bar'), equals(['foo', 'bar']));
+      expect(builder.split(r'foo\bar\baz'), equals(['foo', 'bar', 'baz']));
+      expect(builder.split(r'foo\..\bar\.\baz'),
+          equals(['foo', '..', 'bar', '.', 'baz']));
+      expect(builder.split(r'foo\\bar\\\baz'), equals(['foo', 'bar', 'baz']));
+      expect(builder.split(r'foo\/\baz'), equals(['foo', 'baz']));
+    });
+
+    test('includes the root for absolute paths', () {
+      expect(builder.split(r'C:\foo\bar\baz'), equals(['C:\\', 'foo', 'bar', 'baz']));

[Bob Nystrom, 2012/12/12 00:01:20]

Long line.

[nweiz, 2012/12/12 00:50:37]

Done.

+      expect(builder.split(r'C:\\'), equals(['C:\\']));
+
+      // TODO(nweiz): enable these once issue 7323 is fixed.
+      // expect(builder.split(r'\\server\foo\bar\baz'),
+      //     equals(['\\\\server\\', 'foo', 'bar', 'baz']));
+      // expect(builder.split('\\\\server\\'), equals(['\\\\server\\']));
+    });
   });
 
   group('normalize', () {
     test('simple cases', () {
       expect(builder.normalize(''), '');
       expect(builder.normalize('.'), '.');
       expect(builder.normalize('..'), '..');
       expect(builder.normalize('a'), 'a');
       expect(builder.normalize('C:/'), r'C:/');
       expect(builder.normalize(r'C:\'), r'C:\');
@@ skipping 116 matching lines @@
         expect(r.relative(r'..\a/b.txt'), r'..\a\b.txt');
         expect(r.relative(r'a\./b\../c.txt'), r'a\c.txt');
       });
     });
 
     test('from a root with extension', () {
       var r = new path.Builder(style: path.Style.windows, root: r'C:\dir.ext');
       expect(r.relative(r'C:\dir.ext\file'), 'file');
     });
 
+    test('with a root parameter', () {
+      expect(builder.relative(r'C:\foo\bar\baz', to: r'C:\foo\bar'), equals('baz'));

[Bob Nystrom, 2012/12/12 00:01:20]

Long line.

[nweiz, 2012/12/12 00:50:37]

Done.

+    });
+
     test('given absolute with different root prefix', () {
       expect(builder.relative(r'D:\a\b'), r'D:\a\b');
       expect(builder.relative(r'\\a\b'), r'\\a\b');
     });
   });
 
   group('resolve', () {
     test('allows up to seven parts', () {
       expect(builder.resolve('a'), r'C:\root\path\a');
       expect(builder.resolve('a', 'b'), r'C:\root\path\a\b');
@@ skipping 30 matching lines @@
     expect(builder.withoutExtension(r'a\b\'), r'a\b\');
     expect(builder.withoutExtension(r'a\.'), r'a\.');
     expect(builder.withoutExtension(r'a\.b'), r'a\.b');
     expect(builder.withoutExtension(r'a.b\c'), r'a.b\c');
     expect(builder.withoutExtension(r'a/b.c/d'), r'a/b.c/d');
     expect(builder.withoutExtension(r'a\b/c'), r'a\b/c');
     expect(builder.withoutExtension(r'a\b/c.d'), r'a\b/c');
     expect(builder.withoutExtension(r'a.b/c'), r'a.b/c');
   });
 }