Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Unified Diff: mojo/services/authenticating_url_loader/public/interfaces/authenticating_url_loader_factory.mojom

Issue 1155283003: Change AuthenticatingURLLoader to be a URLLoaderInterceptor (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Address review Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/services/authenticating_url_loader/public/interfaces/authenticating_url_loader_factory.mojom
diff --git a/mojo/services/authenticating_url_loader/public/interfaces/authenticating_url_loader_factory.mojom b/mojo/services/authenticating_url_loader/public/interfaces/authenticating_url_loader_factory.mojom
index ed4012ca93e7ae14135cf74a6560e1ae3adb5100..25c304873da6f5047bb7cb2e26f0c3b0bdc43fe6 100644
--- a/mojo/services/authenticating_url_loader/public/interfaces/authenticating_url_loader_factory.mojom
+++ b/mojo/services/authenticating_url_loader/public/interfaces/authenticating_url_loader_factory.mojom
@@ -4,18 +4,14 @@
module mojo;
-import "authenticating_url_loader/public/interfaces/authenticating_url_loader.mojom";
import "authentication/public/interfaces/authentication.mojom";
+import "network/public/interfaces/url_loader_interceptor.mojom";
interface AuthenticatingURLLoaderFactory {
- // Sets the AuthenticationService that any loaders created via
- // |CreateAuthenticatingURLLoader()| will use to obtain tokens with which to
- // authenticate the user.
- SetAuthenticationService(
+ // Creates a URLLoaderInterceptorFactory whose interceptors authenticate via
+ // |authentication_service|. If the connection to |authentication_service| is
+ // lost, the loaders will fail any requests that require authentication.
+ CreateURLLoaderInterceptorFactory(
+ URLLoaderInterceptorFactory& factory_request,
authentication.AuthenticationService authentication_service);
-
- // Creates an AuthenticatingURLLoader that uses |authentication_service| for
- // authentication. If the AuthenticationService has not been set on this
- // factory, the loader will fail any requests that require authentication.
- CreateAuthenticatingURLLoader(AuthenticatingURLLoader& loader_request);
};

Powered by Google App Engine
This is Rietveld 408576698