Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1155273002: Replace XFA_HWIDGET with IXFA_Widget* (Closed)

Created:
5 years, 7 months ago by Tom Sepez
Modified:
5 years, 6 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@ixfa_doc
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Replace XFA_HWIDGET with IXFA_Widget* A second case of casting willy-nilly between unrelated structures to provide information hiding. Bad Idea. Remove dozens of casts in the process. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/eed467dcf3c661cddaecf4f996bc8964e7090cf9

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+393 lines, -386 lines) Patch
M fpdfsdk/include/fpdfxfa/fpdfxfa_doc.h View 1 3 chunks +10 lines, -10 lines 0 comments Download
M fpdfsdk/include/fsdk_annothandler.h View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/include/fsdk_baseannot.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/fsdk_baseform.h View 1 2 5 chunks +12 lines, -12 lines 0 comments Download
M fpdfsdk/include/fsdk_mgr.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/fpdfformfill.cpp View 9 chunks +9 lines, -9 lines 0 comments Download
M fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp View 7 chunks +7 lines, -7 lines 0 comments Download
M fpdfsdk/src/fsdk_annothandler.cpp View 6 chunks +7 lines, -9 lines 0 comments Download
M fpdfsdk/src/fsdk_baseform.cpp View 18 chunks +20 lines, -20 lines 0 comments Download
M fpdfsdk/src/fsdk_mgr.cpp View 4 chunks +3 lines, -4 lines 0 comments Download
M xfa/include/fxfa/fxfa.h View 1 9 chunks +75 lines, -69 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffchoicelist.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffdocview.h View 2 chunks +9 lines, -9 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffdocview.cpp View 6 chunks +14 lines, -14 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffnotify.h View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffnotify.cpp View 7 chunks +9 lines, -9 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffpageview.h View 3 chunks +15 lines, -15 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffpageview.cpp View 5 chunks +26 lines, -26 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffsignature.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxfa/src/app/xfa_fftextedit.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffwidget.h View 2 chunks +5 lines, -1 line 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffwidgetacc.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffwidgethandler.h View 2 chunks +44 lines, -44 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffwidgethandler.cpp View 4 chunks +103 lines, -103 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_fwladapter.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_rendercontext.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxfa/src/common/xfa_document.h View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/src/fxfa/src/parser/xfa_script_hostpseudomodel.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxfa/src/parser/xfa_script_layoutpseudomodel.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Tom Sepez
Lei, part 3 of this cleanup.
5 years, 7 months ago (2015-05-26 21:44:52 UTC) #2
Lei Zhang
lgtm
5 years, 6 months ago (2015-05-30 06:35:34 UTC) #3
Tom Sepez
5 years, 6 months ago (2015-06-02 17:35:32 UTC) #4
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
eed467dcf3c661cddaecf4f996bc8964e7090cf9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698