Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(147)

Issue 1155243007: [BackgroundSync] One-shots should fire only when online (Closed)

Created:
4 years, 11 months ago by jkarlin
Modified:
4 years, 11 months ago
Reviewers:
Peter Beverloo
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[BackgroundSync] One-shots should fire only when online BUG=495172 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196283

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/modules/background_sync/SyncManager.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
jkarlin
Peter: PTAL, many thanks!
4 years, 11 months ago (2015-06-01 17:58:20 UTC) #2
Peter Beverloo
lgtm, much better :) Will developers be able to toggle such constraints for one-off syncs?
4 years, 11 months ago (2015-06-01 18:01:54 UTC) #3
jkarlin
On 2015/06/01 18:01:54, Peter Beverloo wrote: > lgtm, much better :) > > Will developers ...
4 years, 11 months ago (2015-06-01 18:03:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1155243007/1
4 years, 11 months ago (2015-06-01 18:04:56 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/64622)
4 years, 11 months ago (2015-06-01 23:35:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1155243007/1
4 years, 11 months ago (2015-06-02 02:19:50 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2015-06-02 04:42:50 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196283

Powered by Google App Engine
This is Rietveld 408576698