Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Side by Side Diff: third_party/libaddressinput/chromium/cpp/test/retriever_test.cc

Issue 115523011: [rAc - libaddressinput] slay a Helper class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: assert instead Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « third_party/libaddressinput/chromium/cpp/src/retriever.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (C) 2013 Google Inc. 1 // Copyright (C) 2013 Google Inc.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
(...skipping 104 matching lines...) Expand 10 before | Expand all | Expand 10 after
115 Retriever bad_retriever(FakeDownloader::kFakeDataUrl, 115 Retriever bad_retriever(FakeDownloader::kFakeDataUrl,
116 scoped_ptr<const Downloader>(new FaultyDownloader), 116 scoped_ptr<const Downloader>(new FaultyDownloader),
117 scoped_ptr<Storage>(new FakeStorage)); 117 scoped_ptr<Storage>(new FakeStorage));
118 bad_retriever.Retrieve(kKey, BuildCallback()); 118 bad_retriever.Retrieve(kKey, BuildCallback());
119 119
120 EXPECT_FALSE(success_); 120 EXPECT_FALSE(success_);
121 EXPECT_EQ(kKey, key_); 121 EXPECT_EQ(kKey, key_);
122 EXPECT_TRUE(data_.empty()); 122 EXPECT_TRUE(data_.empty());
123 } 123 }
124 124
125 // The downloader that doesn't get back to you.
126 class HangingDownloader : public Downloader {
127 public:
128 HangingDownloader() {}
129 virtual ~HangingDownloader() {}
130
131 // Downloader implementation.
132 virtual void Download(const std::string& url,
133 scoped_ptr<Callback> downloaded) const {}
134 };
135
136 TEST_F(RetrieverTest, RequestsDontStack) {
137 Retriever slow_retriever(FakeDownloader::kFakeDataUrl,
138 scoped_ptr<const Downloader>(new HangingDownloader),
139 scoped_ptr<Storage>(new FakeStorage));
140
141 slow_retriever.Retrieve(kKey, BuildCallback());
142 EXPECT_FALSE(success_);
143 EXPECT_TRUE(key_.empty());
144
145 #if !defined(NDEBUG)
146 // This request should cause an assert.
147 ASSERT_DEATH(slow_retriever.Retrieve(kKey, BuildCallback()), "");
148 #endif
149 }
150
125 } // namespace 151 } // namespace
126 152
127 } // namespace addressinput 153 } // namespace addressinput
128 } // namespace i18n 154 } // namespace i18n
OLDNEW
« no previous file with comments | « third_party/libaddressinput/chromium/cpp/src/retriever.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698