Stop generating webkit_resources.rc from webkit_resources.grd.

Stop generating webkit_resources.rc from webkit_resources.grd.

Fixes a TODO.

BUG=297672
TBR=avi

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243238

[Nico, 2014-01-06 21:21:06]

A question about https://chromiumcodereview.appspot.com/11418003 : How did you
find out which rc files can be removed? How did you test that they weren't
needed by anything?

[oshima, 2014-01-06 22:37:40]

On 2014/01/06 21:21:06, Nico wrote:
> A question about https://chromiumcodereview.appspot.com/11418003 : How did you
> find out which rc files can be removed?

These resources that need 1x and 2x were moved out from rc file into separate
pak files
so that they can be switched (they used to be embedded in dll). See
chrome/chrome_repack_{100|200}_percenet.gypi.
Did you find any issue with this?

>  How did you test that they weren't needed by anything?

Missing resource results in check failure in waterfall/try bots. That's how
DumpRenderTree issue was caught.

[Nico, 2014-01-06 22:39:09]

On Mon, Jan 6, 2014 at 2:37 PM, <oshima@chromium.org> wrote:

> On 2014/01/06 21:21:06, Nico wrote:
>
>> A question about https://chromiumcodereview.appspot.com/11418003 : How
>> did you
>> find out which rc files can be removed?
>>
>
> These resources that need 1x and 2x were moved out from rc file into
> separate
> pak files
> so that they can be switched (they used to be embedded in dll). See
> chrome/chrome_repack_{100|200}_percenet.gypi.
> Did you find any issue with this?


No, just curious. I'd like to remove more .rc files if possible.


>
>
>    How did you test that they weren't needed by anything?
>>
>
> Missing resource results in check failure in waterfall/try bots. That's how
> DumpRenderTree issue was caught.
>

Since DRT no longer exists, this CL might work, right?


>
>
> https://codereview.chromium.org/115523007/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[oshima, 2014-01-06 22:46:54]

On 2014/01/06 22:39:09, Nico wrote:
> On Mon, Jan 6, 2014 at 2:37 PM, <mailto:oshima@chromium.org> wrote:
> 
> > On 2014/01/06 21:21:06, Nico wrote:
> >
> >> A question about https://chromiumcodereview.appspot.com/11418003 : How
> >> did you
> >> find out which rc files can be removed?
> >>
> >
> > These resources that need 1x and 2x were moved out from rc file into
> > separate
> > pak files
> > so that they can be switched (they used to be embedded in dll). See
> > chrome/chrome_repack_{100|200}_percenet.gypi.
> > Did you find any issue with this?
> 
> 
> No, just curious. I'd like to remove more .rc files if possible.
> 
> 
> >
> >
> >    How did you test that they weren't needed by anything?
> >>
> >
> > Missing resource results in check failure in waterfall/try bots. That's how
> > DumpRenderTree issue was caught.
> >
> 
> Since DRT no longer exists, this CL might work, right?

Yes, lgtm.


> 
> 
> >
> >
> > https://codereview.chromium.org/115523007/
> >
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2014-01-06 22:55:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/115523007/1

[commit-bot: I haz the power, 2014-01-06 23:17:51]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[commit-bot: I haz the power, 2014-01-06 23:27:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/115523007/1

[commit-bot: I haz the power, 2014-01-07 10:17:26]

Change committed as 243238