Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1155223002: [bindings] Use |PostMessage| attribute for Client.postMessage to eliminate custom bindings (Closed)

Created:
5 years, 7 months ago by vivekg_samsung
Modified:
5 years, 7 months ago
Reviewers:
haraken, falken, vivekg
CC:
vivekg, arv+blink, blink-reviews, blink-reviews-bindings_chromium.org, falken, horo+watch_chromium.org, jsbell+serviceworker_chromium.org, kinuko+serviceworker, michaeln, nhiroki, serviceworker-reviews, tzik, vivekg_samsung
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[bindings] Use |PostMessage| attribute for Client.postMessage to eliminate custom bindings BUG=345519 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195947

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -22 lines) Patch
D Source/bindings/modules/v8/custom/V8ClientCustom.cpp View 1 chunk +0 lines, -19 lines 0 comments Download
M Source/bindings/modules/v8/custom/custom.gni View 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/modules/v8/custom/custom.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/serviceworkers/Client.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
vivekg
PTAL, thanks!
5 years, 7 months ago (2015-05-26 19:13:05 UTC) #2
haraken
LGTM
5 years, 7 months ago (2015-05-26 23:19:43 UTC) #3
falken
lgtm
5 years, 7 months ago (2015-05-27 00:44:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1155223002/1
5 years, 7 months ago (2015-05-27 00:50:33 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-27 01:05:24 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195947

Powered by Google App Engine
This is Rietveld 408576698