Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(881)

Unified Diff: src/lithium.cc

Issue 11552033: This patch is the propagation version of https://codereview.chromium.org/10824032 patch (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/lithium.cc
===================================================================
--- src/lithium.cc (revision 13419)
+++ src/lithium.cc (working copy)
@@ -416,6 +416,11 @@
Handle<Code> LChunk::Codegen(Code::Kind kind) {
MacroAssembler assembler(info()->isolate(), NULL, 0);
+ if (info()->isolate()->logger()->is_code_event_handler_enabled()) {
danno 2013/02/01 13:43:10 Other Logger APIs do "is_enabled" checking inside
+ void* line_info =
danno 2013/02/01 13:43:10 This should be jit_handler_data
+ info()->isolate()->logger()->CodeStartLinePosInfoRecordEvent();
+ assembler.positions_recorder()->InitializeUserData(line_info);
danno 2013/02/01 13:43:10 InitializeUserData should be InitializeJitHandlerD
+ }
LCodeGen generator(this, &assembler, info());
MarkEmptyBlocks();
@@ -429,6 +434,15 @@
Handle<Code> code =
CodeGenerator::MakeCodeEpilogue(&assembler, flags, info());
generator.FinishCode(code);
+
+ if (info()->isolate()->logger()->is_code_event_handler_enabled()) {
+ if (!code.is_null()) {
+ void* line_info =
+ assembler.positions_recorder()->DetachJITLineInfo();
+ LOG_CODE_EVENT(info()->isolate(),
+ CodeEndLinePosInfoRecordEvent(*code, line_info));
danno 2013/02/01 13:43:10 line_info -> jit_handler_data
+ }
+ }
CodeGenerator::PrintCode(code, info());
return code;
}

Powered by Google App Engine
This is Rietveld 408576698