Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: src/assembler.cc

Issue 11552033: This patch is the propagation version of https://codereview.chromium.org/10824032 patch (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/assembler.cc
===================================================================
--- src/assembler.cc (revision 13419)
+++ src/assembler.cc (working copy)
@@ -1522,6 +1522,13 @@
gdbjit_lineinfo_->SetPosition(assembler_->pc_offset(), pos, false);
}
#endif
+ if (user_data_ != NULL) {
danno 2013/02/01 13:43:10 Why conditionally call? It seems like you should _
+ LOG_CODE_EVENT(this->assembler()->isolate(),
+ CodeLinePosInfoAddEvent(user_data_,
+ assembler_->pc_offset(),
+ pos,
+ JitCodeEvent::POSITION));
+ }
}
@@ -1534,6 +1541,13 @@
gdbjit_lineinfo_->SetPosition(assembler_->pc_offset(), pos, true);
}
#endif
+ if (user_data_ != NULL) {
danno 2013/02/01 13:43:10 Same comment as above (please always call LOG_CODE
+ LOG_CODE_EVENT(this->assembler()->isolate(),
+ CodeLinePosInfoAddEvent(user_data_,
+ assembler_->pc_offset(),
+ pos,
+ JitCodeEvent::STATEMENT_POSITION));
+ }
}

Powered by Google App Engine
This is Rietveld 408576698