Make hitting "Enter" submit the add/change profile dialog.

chrome/browser/resources/options/manage_profile_overlay.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
   var OptionsPage = options.OptionsPage;
   var ArrayDataModel = cr.ui.ArrayDataModel;
 
   /**
    * ManageProfileOverlay class
@@ skipping 55 matching lines @@
       $('manage-profile-ok').onclick = function(event) {
         OptionsPage.closeOverlay();
         self.submitManageChanges_();
       };
       $('delete-profile-ok').onclick = function(event) {
         OptionsPage.closeOverlay();
         chrome.send('deleteProfile', [self.profileInfo_.filePath]);
       };
       $('create-profile-ok').onclick = function(event) {
         OptionsPage.closeOverlay();
-        // Get the user's chosen name and icon, or default if they do not
-        // wish to customize their profile.
-        var name = $('create-profile-name').value;
-        var icon_url = createIconGrid.selectedItem;
-        var create_checkbox = false;
-        if ($('create-shortcut'))
-          create_checkbox = $('create-shortcut').checked;
-        chrome.send('createProfile', [name, icon_url, create_checkbox]);
+        self.submitCreateProfile_();
+      };
+      $('manage-profile-name').onkeydown =
+          $('manage-profile-icon-grid').onkeydown = function(event) {
+        if (!$('manage-profile-ok').disabled && event.keyCode == 13) {  // Enter
+          OptionsPage.closeOverlay();
+          self.submitManageChanges_();
+        }
+      };
+      $('create-profile-name').onkeydown =
+          $('create-profile-icon-grid').onkeydown = function(event) {
+        if (!$('create-profile-ok').disabled && event.keyCode == 13) {  // Enter
+          OptionsPage.closeOverlay();
+          self.submitCreateProfile_();
+        }

[csilv, 2012/12/15 01:05:12]

These two methods are identical, so it would be nice to put the implementation
into a method that can be shared.

[Rune Fevang, 2012/12/18 02:47:02]

Done.

       };
     },
 
     /** @override */
     didShowPage: function() {
       chrome.send('requestDefaultProfileIcons');
 
       if ($('create-shortcut'))
         $('create-shortcut').checked = true;
       if ($('manage-shortcut'))
@@ skipping 112 matching lines @@
         this.showErrorBubble_('manageProfilesDuplicateNameError', mode);
       } else {
         this.hideErrorBubble_(mode);
 
         var nameIsValid = $(mode + '-profile-name').validity.valid;
         $(mode + '-profile-ok').disabled = !nameIsValid;
       }
     },
 
     /**
-     * Called when the user clicks "OK". Saves the newly changed profile info.
+     * Called when the user clicks "OK" or hits enter. Saves the newly changed
+     * profile info.
      * @private
      */
     submitManageChanges_: function() {
       var name = $('manage-profile-name').value;
       var iconURL = $('manage-profile-icon-grid').selectedItem;
       var manage_checkbox = false;
       if ($('manage-shortcut'))
         manage_checkbox = $('manage-shortcut').checked;
       chrome.send('setProfileNameAndIcon',
                   [this.profileInfo_.filePath, name, iconURL,
                   manage_checkbox]);
     },
 
     /**
+     * Called when the user clicks "OK" or hits enter. Creates the profile
+     * using the information in the dialog.
+     * @private
+     */
+    submitCreateProfile_: function() {
+      // Get the user's chosen name and icon, or default if they do not
+      // wish to customize their profile.
+      var name = $('create-profile-name').value;
+      var icon_url = $('create-profile-icon-grid').selectedItem;
+      var create_checkbox = false;
+      if ($('create-shortcut'))
+        create_checkbox = $('create-shortcut').checked;
+      chrome.send('createProfile', [name, icon_url, create_checkbox]);
+    },
+
+    /**
      * Called when the selected icon in the icon grid changes.
      * @param {String} mode A label that specifies the type of dialog
      *     box which is currently being viewed (i.e. 'create' or
      *     'manage').
      * @private
      */
     onIconGridSelectionChanged_: function(mode) {
       var iconURL = $(mode + '-profile-icon-grid').selectedItem;
       if (!iconURL || iconURL == this.iconGridSelectedURL_)
         return;
@@ skipping 79 matching lines @@
       var instance = ManageProfileOverlay.getInstance();
       return instance[name + '_'].apply(instance, arguments);
     };
   });
 
   // Export
   return {
     ManageProfileOverlay: ManageProfileOverlay
   };
 });