Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 11552029: Make hitting "Enter" submit the add/change profile dialog. (Closed)

Created:
8 years ago by Rune Fevang
Modified:
7 years, 11 months ago
Reviewers:
csilv
CC:
chromium-reviews, dbeam+watch-options_chromium.org, arv (Not doing code reviews)
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Make hitting "Enter" submit the add/change profile dialog. BUG=102172 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175586

Patch Set 1 #

Patch Set 2 : Respect OK button disabled state #

Total comments: 2

Patch Set 3 : Share event registration code between 'create' and 'manage' #

Patch Set 4 : Black border around OK buttons #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -34 lines) Patch
M chrome/browser/resources/options/manage_profile_overlay.css View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/resources/options/manage_profile_overlay.js View 1 2 3 5 chunks +57 lines, -34 lines 0 comments Download

Messages

Total messages: 21 (0 generated)
Rune Fevang
8 years ago (2012-12-13 01:16:07 UTC) #1
Rune Fevang
Hey csilv, I added you since you were in the OWNERS file. If you're the ...
8 years ago (2012-12-14 22:29:20 UTC) #2
csilv
One issue I foresee is that this issue will not work if the user clicks ...
8 years ago (2012-12-15 01:05:12 UTC) #3
Rune Fevang
On 2012/12/15 01:05:12, csilv wrote: > One issue I foresee is that this issue will ...
8 years ago (2012-12-15 01:38:24 UTC) #4
Rune Fevang
Registering for events on the overlay itself didn't help in the 'lost focus' case, so ...
8 years ago (2012-12-18 02:47:02 UTC) #5
Rune Fevang
Ping, any chance of getting this looked at before the holiday break?
8 years ago (2012-12-21 20:53:42 UTC) #6
Dan Beam
this is a lot of changes, can't you just wrap with a <form> and say ...
8 years ago (2012-12-21 21:42:42 UTC) #7
Dan Beam
or perhaps something more generically useful using event delegation?
8 years ago (2012-12-21 21:45:47 UTC) #8
Rune Fevang
On 2012/12/21 21:42:42, Dan Beam wrote: > this is a lot of changes, can't you ...
8 years ago (2012-12-21 22:59:19 UTC) #9
Dan Beam
On 2012/12/21 22:59:19, Rune Fevang wrote: > On 2012/12/21 21:42:42, Dan Beam wrote: > > ...
8 years ago (2012-12-22 02:59:10 UTC) #10
csilv
lgtm Rune, sorry for neglecting this issue for so long. The change itself looks good. ...
7 years, 11 months ago (2013-01-04 20:20:43 UTC) #11
Rune Fevang
On 2013/01/04 20:20:43, csilv wrote: > lgtm > > Rune, sorry for neglecting this issue ...
7 years, 11 months ago (2013-01-05 01:06:51 UTC) #12
csilv
Thanks for adding the border, slgtm.
7 years, 11 months ago (2013-01-05 01:18:34 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rfevang@chromium.org/11552029/19001
7 years, 11 months ago (2013-01-05 04:32:37 UTC) #14
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) sync_unit_tests, unit_tests
7 years, 11 months ago (2013-01-05 04:52:53 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rfevang@chromium.org/11552029/19001
7 years, 11 months ago (2013-01-07 17:53:22 UTC) #16
commit-bot: I haz the power
Retried try job too often on win_aura for step(s) interactive_ui_tests
7 years, 11 months ago (2013-01-07 21:57:37 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rfevang@chromium.org/11552029/19001
7 years, 11 months ago (2013-01-08 18:44:12 UTC) #18
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 11 months ago (2013-01-08 18:51:52 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rfevang@chromium.org/11552029/19001
7 years, 11 months ago (2013-01-08 18:59:01 UTC) #20
commit-bot: I haz the power
7 years, 11 months ago (2013-01-08 21:56:58 UTC) #21
Message was sent while issue was closed.
Change committed as 175586

Powered by Google App Engine
This is Rietveld 408576698