Chromium Code Reviews| Index: chrome/browser/webdata/web_database_migration_unittest.cc |
| diff --git a/chrome/browser/webdata/web_database_migration_unittest.cc b/chrome/browser/webdata/web_database_migration_unittest.cc |
| index de4de0849a7332797a0e43c5252949e1096ec331..972bf7a3dd37c000c82c9de5d4f13829d7896ed6 100644 |
| --- a/chrome/browser/webdata/web_database_migration_unittest.cc |
| +++ b/chrome/browser/webdata/web_database_migration_unittest.cc |
| @@ -213,7 +213,7 @@ class WebDatabaseMigrationTest : public testing::Test { |
| DISALLOW_COPY_AND_ASSIGN(WebDatabaseMigrationTest); |
| }; |
| -const int WebDatabaseMigrationTest::kCurrentTestedVersionNumber = 48; |
| +const int WebDatabaseMigrationTest::kCurrentTestedVersionNumber = 49; |
| void WebDatabaseMigrationTest::LoadDatabase(const FilePath::StringType& file) { |
| std::string contents; |
| @@ -2056,3 +2056,46 @@ TEST_F(WebDatabaseMigrationTest, MigrateVersion47ToCurrent) { |
| EXPECT_NO_FATAL_FAILURE(CheckNoBackupData(connection, &meta_table)); |
| } |
| } |
| + |
| +// Tests that the |search_terms_replacement_key| column is added to the keyword |
| +// table schema for a version 49 database. |
| +TEST_F(WebDatabaseMigrationTest, MigrateVersion48ToCurrent) { |
| + ASSERT_NO_FATAL_FAILURE( |
| + LoadDatabase(FILE_PATH_LITERAL("version_48.sql"))); |
| + |
| + // Verify pre-conditions. These are expectations for version 48 of the |
| + // database. |
| + { |
| + sql::Connection connection; |
| + ASSERT_TRUE(connection.Open(GetDatabasePath())); |
| + ASSERT_TRUE(sql::MetaTable::DoesTableExist(&connection)); |
| + |
| + sql::MetaTable meta_table; |
| + ASSERT_TRUE(meta_table.Init(&connection, 48, 48)); |
| + |
| + ASSERT_FALSE(connection.DoesColumnExist("keywords", |
| + "search_terms_replacement_key")); |
| + } |
| + |
| + // Load the database via the WebDatabase class and migrate the database to |
| + // the current version. |
| + { |
| + WebDatabase db; |
| + ASSERT_EQ(sql::INIT_OK, db.Init(GetDatabasePath())); |
| + } |
| + |
| + // Verify post-conditions. These are expectations for current version of the |
| + // database. |
| + { |
| + sql::Connection connection; |
| + ASSERT_TRUE(connection.Open(GetDatabasePath())); |
| + ASSERT_TRUE(sql::MetaTable::DoesTableExist(&connection)); |
| + |
| + // Check version. |
| + EXPECT_EQ(kCurrentTestedVersionNumber, VersionFromConnection(&connection)); |
| + |
| + // A new column should have been created. |
| + EXPECT_TRUE(connection.DoesColumnExist("keywords", |
| + "search_terms_replacement_key")); |
|
akalin
2012/12/20 17:13:59
fix indent
beaudoin
2013/01/03 18:49:40
Done.
|
| + } |
| +} |