Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(624)

Side by Side Diff: chrome/browser/search_engines/template_url.cc

Issue 11552020: Add search_terms_replacement_key field to TemplateURL. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Removed logic to check search_terms_replacement_key in template_url.cc. This is for a next CL. Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/search_engines/template_url.h" 5 #include "chrome/browser/search_engines/template_url.h"
6 6
7 #include "base/guid.h" 7 #include "base/guid.h"
8 #include "base/i18n/case_conversion.h" 8 #include "base/i18n/case_conversion.h"
9 #include "base/i18n/icu_string_conversions.h" 9 #include "base/i18n/icu_string_conversions.h"
10 #include "base/i18n/rtl.h" 10 #include "base/i18n/rtl.h"
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
50 const char kGoogleBaseURLParameter[] = "google:baseURL"; 50 const char kGoogleBaseURLParameter[] = "google:baseURL";
51 const char kGoogleBaseURLParameterFull[] = "{google:baseURL}"; 51 const char kGoogleBaseURLParameterFull[] = "{google:baseURL}";
52 52
53 // Like google:baseURL, but for the Search Suggest capability. 53 // Like google:baseURL, but for the Search Suggest capability.
54 const char kGoogleBaseSuggestURLParameter[] = "google:baseSuggestURL"; 54 const char kGoogleBaseSuggestURLParameter[] = "google:baseSuggestURL";
55 const char kGoogleBaseSuggestURLParameterFull[] = "{google:baseSuggestURL}"; 55 const char kGoogleBaseSuggestURLParameterFull[] = "{google:baseSuggestURL}";
56 56
57 const char kGoogleInstantEnabledParameter[] = "google:instantEnabledParameter"; 57 const char kGoogleInstantEnabledParameter[] = "google:instantEnabledParameter";
58 const char kGoogleInstantExtendedEnabledParameter[] = 58 const char kGoogleInstantExtendedEnabledParameter[] =
59 "google:instantExtendedEnabledParameter"; 59 "google:instantExtendedEnabledParameter";
60 const char kGoogleInstantExtendedEnabledKey[] =
61 "google:instantExtendedEnabledKey";
60 const char kGoogleOriginalQueryForSuggestionParameter[] = 62 const char kGoogleOriginalQueryForSuggestionParameter[] =
61 "google:originalQueryForSuggestion"; 63 "google:originalQueryForSuggestion";
62 const char kGoogleRLZParameter[] = "google:RLZ"; 64 const char kGoogleRLZParameter[] = "google:RLZ";
63 const char kGoogleSearchClient[] = "google:searchClient"; 65 const char kGoogleSearchClient[] = "google:searchClient";
64 const char kGoogleSearchFieldtrialParameter[] = 66 const char kGoogleSearchFieldtrialParameter[] =
65 "google:searchFieldtrialParameter"; 67 "google:searchFieldtrialParameter";
66 const char kGoogleSourceIdParameter[] = "google:sourceId"; 68 const char kGoogleSourceIdParameter[] = "google:sourceId";
67 const char kGoogleSuggestAPIKeyParameter[] = "google:suggestAPIKeyParameter"; 69 const char kGoogleSuggestAPIKeyParameter[] = "google:suggestAPIKeyParameter";
68 70
69 // Same as kSearchTermsParameter, with no escaping. 71 // Same as kSearchTermsParameter, with no escaping.
(...skipping 227 matching lines...) Expand 10 before | Expand all | Expand 10 after
297 break; 299 break;
298 300
299 case GOOGLE_INSTANT_ENABLED: 301 case GOOGLE_INSTANT_ENABLED:
300 url.insert(i->index, search_terms_data.InstantEnabledParam()); 302 url.insert(i->index, search_terms_data.InstantEnabledParam());
301 break; 303 break;
302 304
303 case GOOGLE_INSTANT_EXTENDED_ENABLED: 305 case GOOGLE_INSTANT_EXTENDED_ENABLED:
304 url.insert(i->index, search_terms_data.InstantExtendedEnabledParam()); 306 url.insert(i->index, search_terms_data.InstantExtendedEnabledParam());
305 break; 307 break;
306 308
309 case GOOGLE_INSTANT_EXTENDED_ENABLED_KEY:
310 url.insert(i->index, search_terms_data.InstantExtendedEnabledKey());
311 break;
312
307 case GOOGLE_ORIGINAL_QUERY_FOR_SUGGESTION: 313 case GOOGLE_ORIGINAL_QUERY_FOR_SUGGESTION:
308 if (search_terms_args.accepted_suggestion >= 0 || 314 if (search_terms_args.accepted_suggestion >= 0 ||
309 !search_terms_args.assisted_query_stats.empty()) { 315 !search_terms_args.assisted_query_stats.empty()) {
310 url.insert(i->index, "oq=" + UTF16ToUTF8(encoded_original_query) + 316 url.insert(i->index, "oq=" + UTF16ToUTF8(encoded_original_query) +
311 "&"); 317 "&");
312 } 318 }
313 break; 319 break;
314 320
315 case GOOGLE_RLZ: { 321 case GOOGLE_RLZ: {
316 // On platforms that don't have RLZ, we still want this branch 322 // On platforms that don't have RLZ, we still want this branch
(...skipping 236 matching lines...) Expand 10 before | Expand all | Expand 10 after
553 replacements->push_back(Replacement(GOOGLE_ASSISTED_QUERY_STATS, start)); 559 replacements->push_back(Replacement(GOOGLE_ASSISTED_QUERY_STATS, start));
554 } else if (parameter == kGoogleBaseURLParameter) { 560 } else if (parameter == kGoogleBaseURLParameter) {
555 replacements->push_back(Replacement(GOOGLE_BASE_URL, start)); 561 replacements->push_back(Replacement(GOOGLE_BASE_URL, start));
556 } else if (parameter == kGoogleBaseSuggestURLParameter) { 562 } else if (parameter == kGoogleBaseSuggestURLParameter) {
557 replacements->push_back(Replacement(GOOGLE_BASE_SUGGEST_URL, start)); 563 replacements->push_back(Replacement(GOOGLE_BASE_SUGGEST_URL, start));
558 } else if (parameter == kGoogleInstantEnabledParameter) { 564 } else if (parameter == kGoogleInstantEnabledParameter) {
559 replacements->push_back(Replacement(GOOGLE_INSTANT_ENABLED, start)); 565 replacements->push_back(Replacement(GOOGLE_INSTANT_ENABLED, start));
560 } else if (parameter == kGoogleInstantExtendedEnabledParameter) { 566 } else if (parameter == kGoogleInstantExtendedEnabledParameter) {
561 replacements->push_back(Replacement(GOOGLE_INSTANT_EXTENDED_ENABLED, 567 replacements->push_back(Replacement(GOOGLE_INSTANT_EXTENDED_ENABLED,
562 start)); 568 start));
569 } else if (parameter == kGoogleInstantExtendedEnabledKey) {
570 replacements->push_back(Replacement(GOOGLE_INSTANT_EXTENDED_ENABLED_KEY,
571 start));
563 } else if (parameter == kGoogleOriginalQueryForSuggestionParameter) { 572 } else if (parameter == kGoogleOriginalQueryForSuggestionParameter) {
564 replacements->push_back(Replacement(GOOGLE_ORIGINAL_QUERY_FOR_SUGGESTION, 573 replacements->push_back(Replacement(GOOGLE_ORIGINAL_QUERY_FOR_SUGGESTION,
565 start)); 574 start));
566 } else if (parameter == kGoogleRLZParameter) { 575 } else if (parameter == kGoogleRLZParameter) {
567 replacements->push_back(Replacement(GOOGLE_RLZ, start)); 576 replacements->push_back(Replacement(GOOGLE_RLZ, start));
568 } else if (parameter == kGoogleSearchClient) { 577 } else if (parameter == kGoogleSearchClient) {
569 replacements->push_back(Replacement(GOOGLE_SEARCH_CLIENT, start)); 578 replacements->push_back(Replacement(GOOGLE_SEARCH_CLIENT, start));
570 } else if (parameter == kGoogleSearchFieldtrialParameter) { 579 } else if (parameter == kGoogleSearchFieldtrialParameter) {
571 replacements->push_back(Replacement(GOOGLE_SEARCH_FIELDTRIAL_GROUP, start)); 580 replacements->push_back(Replacement(GOOGLE_SEARCH_FIELDTRIAL_GROUP, start));
572 } else if (parameter == kGoogleSuggestAPIKeyParameter) { 581 } else if (parameter == kGoogleSuggestAPIKeyParameter) {
(...skipping 282 matching lines...) Expand 10 before | Expand all | Expand 10 after
855 } 864 }
856 865
857 void TemplateURL::ResetKeywordIfNecessary(bool force) { 866 void TemplateURL::ResetKeywordIfNecessary(bool force) {
858 if (IsGoogleSearchURLWithReplaceableKeyword() || force) { 867 if (IsGoogleSearchURLWithReplaceableKeyword() || force) {
859 DCHECK(!IsExtensionKeyword()); 868 DCHECK(!IsExtensionKeyword());
860 GURL url(TemplateURLService::GenerateSearchURL(this)); 869 GURL url(TemplateURLService::GenerateSearchURL(this));
861 if (url.is_valid()) 870 if (url.is_valid())
862 data_.SetKeyword(TemplateURLService::GenerateKeyword(url)); 871 data_.SetKeyword(TemplateURLService::GenerateKeyword(url));
863 } 872 }
864 } 873 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698