sky/engine/bindings/scripts/dart_types.py - Issue 1155193004: Canvas.concat takes a 16-element Float32List instead of an array.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/bindings/scripts/dart_types.py

Issue 1155193004: Canvas.concat takes a 16-element Float32List instead of an array. (Closed) Base URL: git@github.com:/domokit/mojo.git@master

Patch Set: more fixes Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/bindings/scripts/dart_types.py

diff --git a/sky/engine/bindings/scripts/dart_types.py b/sky/engine/bindings/scripts/dart_types.py

index dde7436e6110f3bd26fa5d4eb390c3f31ea12e65..d1f07db17ff4acd8163cd5c88f985b20c3100536 100644

--- a/sky/engine/bindings/scripts/dart_types.py

+++ b/sky/engine/bindings/scripts/dart_types.py

@@ -116,6 +116,7 @@ CPP_SPECIAL_CONVERSION_RULES = {

'unrestricted float': 'float',

# Pass these by value, not pointer.

'Color': 'SkColor',

+ 'Float32List': 'Float32List',

'Point': 'Point',

'Rect': 'Rect',

'TransferMode': 'SkXfermode::Mode',

@@ -363,6 +364,7 @@ DART_TO_CPP_VALUE = {

# Pass-by-value types.

'Color': pass_by_value_format('CanvasColor'),

+ 'Float32List': pass_by_value_format('Float32List'),

'Point': pass_by_value_format('{implemented_as}'),

'Rect': pass_by_value_format('{implemented_as}'),

'TransferMode': pass_by_value_format('TransferMode'),

« no previous file with comments | « no previous file | sky/engine/core/painting/Canvas.h » ('j') | no next file with comments »