Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Side by Side Diff: sky/engine/tonic/dart_float32list.h

Issue 1155193004: Canvas.concat takes a 16-element Float32List instead of an array. (Closed) Base URL: git@github.com:/domokit/mojo.git@master
Patch Set: abarth Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef SKY_ENGINE_TONIC_DART_FLOAT32LIST_H_
6 #define SKY_ENGINE_TONIC_DART_FLOAT32LIST_H_
7
8 #include "dart/runtime/include/dart_api.h"
9 #include "sky/engine/tonic/dart_converter.h"
10
11 namespace blink {
12
13 // A simple wrapper around a Dart Float32List. It uses Dart_TypedDataAcquireData
14 // to obtain a raw pointer to the data, which is released when this object is
15 // destroyed.
16 //
17 // This is designed to be used with DartConverter only.
18 class Float32List {
19 public:
20 Float32List(Dart_Handle list);
abarth-chromium 2015/06/04 17:29:28 explicit
Matt Perry 2015/06/04 17:34:36 Done.
21 Float32List(Float32List&& other);
22 ~Float32List();
23
24 const float* data() const { return data_; }
25 size_t num_elements() const { return num_elements_; }
abarth-chromium 2015/06/04 17:29:28 Why the change from intptr_t to size_t? We should
Matt Perry 2015/06/04 17:34:35 Done.
26
27 private:
28 float* data_;
29 intptr_t num_elements_;
30 Dart_Handle dart_handle_;
31
32 Float32List(const Float32List& other) = delete;
33 };
34
35 template <>
36 struct DartConverter<Float32List> {
37 static Float32List FromArgumentsWithNullCheck(Dart_NativeArguments args,
38 int index,
39 Dart_Handle& exception);
40 };
41
42 } // namespace blink
43
44 #endif // SKY_ENGINE_TONIC_DART_FLOAT32LIST_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698