Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 1155193003: Ignore import errors in cr recursive module loading (Closed)

Created:
5 years, 6 months ago by petrcermak
Modified:
5 years, 6 months ago
Reviewers:
Sami
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ignore import errors in cr recursive module loading Without this change, cr throws an ImportError whenever it tries to import a folder with Python containing other folders (without Python code). BUG= Committed: https://crrev.com/9bf5fea4e21eac6a98d4ae6fca5ee84ec352f416 Cr-Commit-Position: refs/heads/master@{#332650}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add _TryImport #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -5 lines) Patch
M tools/cr/cr/loader.py View 1 2 chunks +17 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
petrcermak
Hi, please review this patch. Thanks, Petr
5 years, 6 months ago (2015-06-03 11:01:26 UTC) #2
Sami
The CL description could explain a bit why we need to do this. https://codereview.chromium.org/1155193003/diff/1/tools/cr/cr/loader.py File ...
5 years, 6 months ago (2015-06-03 12:51:24 UTC) #3
petrcermak
Thanks for your comments. PTAL. Petr https://codereview.chromium.org/1155193003/diff/1/tools/cr/cr/loader.py File tools/cr/cr/loader.py (right): https://codereview.chromium.org/1155193003/diff/1/tools/cr/cr/loader.py#newcode81 tools/cr/cr/loader.py:81: module = _Import(name) ...
5 years, 6 months ago (2015-06-03 13:50:35 UTC) #4
Sami
Thanks, lgtm.
5 years, 6 months ago (2015-06-03 14:30:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1155193003/20001
5 years, 6 months ago (2015-06-03 18:16:33 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-03 18:29:03 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-06-03 18:30:57 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9bf5fea4e21eac6a98d4ae6fca5ee84ec352f416
Cr-Commit-Position: refs/heads/master@{#332650}

Powered by Google App Engine
This is Rietveld 408576698