extensions/renderer/logging_native_handler.h - Issue 1155183006: Reimplement automation API on top of C++-backed AXTree.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/logging_native_handler.h

Issue 1155183006: Reimplement automation API on top of C++-backed AXTree. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@automation_faster_2

Patch Set: Copy observers Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/data/extensions/api_test/automation/tests/unit/unit.html ('k') | extensions/renderer/logging_native_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/renderer/logging_native_handler.h

diff --git a/extensions/renderer/logging_native_handler.h b/extensions/renderer/logging_native_handler.h

index e9f4f20e66d1640d9e2675fb3bf69353d8084693..ca9938c27602cce7b4e3391eeaae4d7dc4ea1f43 100644

--- a/extensions/renderer/logging_native_handler.h

+++ b/extensions/renderer/logging_native_handler.h

@@ -46,9 +46,6 @@ class LoggingNativeHandler : public ObjectBackedNativeHandler {

void ParseArgs(const v8::FunctionCallbackInfo<v8::Value>& args,

bool* check_value,

std::string* error_message);

- std::string ToStringOrDefault(const v8::Local<v8::String>& v8_string,

- const std::string& dflt);

};

} // namespace extensions