chrome/browser/extensions/api/automation_internal/automation_event_router.cc - Issue 1155183006: Reimplement automation API on top of C++-backed AXTree.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/automation_internal/automation_event_router.cc

Issue 1155183006: Reimplement automation API on top of C++-backed AXTree. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@automation_faster_2

Patch Set: Fix accessibility_unittest Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/automation/automation_apitest.cc ('k') | chrome/browser/extensions/api/automation_internal/automation_internal_api.cc » ('j') | chrome/renderer/extensions/automation_internal_custom_bindings.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/automation_internal/automation_event_router.cc

diff --git a/chrome/browser/extensions/api/automation_internal/automation_event_router.cc b/chrome/browser/extensions/api/automation_internal/automation_event_router.cc

index 5dee32f19bd90e2bb1a15f99012cee77838984c0..7db3b1b9bfdb2fa41a750a137d5edbc422c99d89 100644

--- a/chrome/browser/extensions/api/automation_internal/automation_event_router.cc

+++ b/chrome/browser/extensions/api/automation_internal/automation_event_router.cc

@@ -62,7 +62,9 @@ void AutomationEventRouter::DispatchAccessibilityEvent(

content::RenderProcessHost* rph =

content::RenderProcessHost::FromID(listener.process_id);

- rph->Send(new ExtensionMsg_AccessibilityEvent(listener.routing_id, params));

+ CHECK(rph);

dcheng 2015/06/15 21:36:54 What's the point of this CHECK?

dmazzoni 2015/06/16 18:19:48 Done.

+ rph->Send(new ExtensionMsg_AccessibilityEvent(listener.routing_id,

+ params));

}

@@ -132,7 +134,7 @@ void AutomationEventRouter::Observe(

listeners_.begin(),

listeners_.end(),

[process_id](AutomationListener& item) {

dcheng 2015/06/15 21:36:55 const AutomationListener& to prevent typos like th

dmazzoni 2015/06/16 18:19:48 Done.

- return item.process_id = process_id;

+ return item.process_id == process_id;

});

}