Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Side by Side Diff: extensions/renderer/logging_native_handler.cc

Issue 1155183006: Reimplement automation API on top of C++-backed AXTree. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@automation_faster_2
Patch Set: Copy observers Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « extensions/renderer/logging_native_handler.h ('k') | extensions/renderer/script_context.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/renderer/logging_native_handler.h"
6
7 #include "base/logging.h" 5 #include "base/logging.h"
8 #include "base/strings/stringprintf.h" 6 #include "base/strings/stringprintf.h"
7 #include "extensions/renderer/logging_native_handler.h"
8 #include "extensions/renderer/script_context.h"
9 9
10 namespace extensions { 10 namespace extensions {
11 11
12 LoggingNativeHandler::LoggingNativeHandler(ScriptContext* context) 12 LoggingNativeHandler::LoggingNativeHandler(ScriptContext* context)
13 : ObjectBackedNativeHandler(context) { 13 : ObjectBackedNativeHandler(context) {
14 RouteFunction( 14 RouteFunction(
15 "DCHECK", 15 "DCHECK",
16 base::Bind(&LoggingNativeHandler::Dcheck, base::Unretained(this))); 16 base::Bind(&LoggingNativeHandler::Dcheck, base::Unretained(this)));
17 RouteFunction( 17 RouteFunction(
18 "CHECK", 18 "CHECK",
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
65 void LoggingNativeHandler::ParseArgs( 65 void LoggingNativeHandler::ParseArgs(
66 const v8::FunctionCallbackInfo<v8::Value>& args, 66 const v8::FunctionCallbackInfo<v8::Value>& args,
67 bool* check_value, 67 bool* check_value,
68 std::string* error_message) { 68 std::string* error_message) {
69 CHECK_LE(args.Length(), 2); 69 CHECK_LE(args.Length(), 2);
70 *check_value = args[0]->BooleanValue(); 70 *check_value = args[0]->BooleanValue();
71 if (args.Length() == 2) { 71 if (args.Length() == 2) {
72 *error_message = "Error: " + std::string(*v8::String::Utf8Value(args[1])); 72 *error_message = "Error: " + std::string(*v8::String::Utf8Value(args[1]));
73 } 73 }
74 74
75 v8::Local<v8::StackTrace> stack_trace = 75 *error_message += "\n" + context()->GetStackTraceAsString();
76 v8::StackTrace::CurrentStackTrace(args.GetIsolate(), 10);
77 if (stack_trace.IsEmpty() || stack_trace->GetFrameCount() <= 0) {
78 *error_message += "\n <no stack trace>";
79 } else {
80 for (size_t i = 0; i < (size_t)stack_trace->GetFrameCount(); ++i) {
81 v8::Local<v8::StackFrame> frame = stack_trace->GetFrame(i);
82 CHECK(!frame.IsEmpty());
83 *error_message += base::StringPrintf(
84 "\n at %s (%s:%d:%d)",
85 ToStringOrDefault(frame->GetFunctionName(), "<anonymous>").c_str(),
86 ToStringOrDefault(frame->GetScriptName(), "<anonymous>").c_str(),
87 frame->GetLineNumber(),
88 frame->GetColumn());
89 }
90 }
91 }
92
93 std::string LoggingNativeHandler::ToStringOrDefault(
94 const v8::Local<v8::String>& v8_string,
95 const std::string& dflt) {
96 if (v8_string.IsEmpty())
97 return dflt;
98 std::string ascii_value = *v8::String::Utf8Value(v8_string);
99 return ascii_value.empty() ? dflt : ascii_value;
100 } 76 }
101 77
102 } // namespace extensions 78 } // namespace extensions
OLDNEW
« no previous file with comments | « extensions/renderer/logging_native_handler.h ('k') | extensions/renderer/script_context.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698