Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1003)

Issue 1155183004: cc: Properly detect when child Surfaces idle (Closed)

Created:
5 years, 7 months ago by brianderson
Modified:
5 years, 6 months ago
Reviewers:
sunnyps, jbauman, mithro-old
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Properly detect when child Surfaces idle all_active_child_surfaces_ready_to_draw_ was not updated properly, which can cause the deadline to run later than necessary when only the root surface consistently has damage, such as during a Browser animation. BUG=492035 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/60bbd25b7306994330adfcee8b4689da266280a0 Cr-Commit-Position: refs/heads/master@{#331887}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -7 lines) Patch
M cc/surfaces/display_scheduler.cc View 2 chunks +15 lines, -7 lines 0 comments Download
M cc/surfaces/display_scheduler_unittest.cc View 2 chunks +20 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
brianderson
ptal
5 years, 7 months ago (2015-05-28 02:02:19 UTC) #2
jbauman
lgtm
5 years, 6 months ago (2015-05-28 21:58:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1155183004/1
5 years, 6 months ago (2015-05-28 22:03:40 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-05-28 23:55:36 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-05-28 23:57:22 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/60bbd25b7306994330adfcee8b4689da266280a0
Cr-Commit-Position: refs/heads/master@{#331887}

Powered by Google App Engine
This is Rietveld 408576698