Build a basic Mojo service framework for device/usb

device/usb/device_manager_impl.cc

Index: device/usb/device_manager_impl.cc
diff --git a/device/usb/device_manager_impl.cc b/device/usb/device_manager_impl.cc
new file mode 100644
index 0000000000000000000000000000000000000000..8849d083affb4ac17ed4b89f5ab57e722c7c7b42
--- /dev/null
+++ b/device/usb/device_manager_impl.cc
@@ -0,0 +1,79 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "device/usb/device_manager_impl.h"
+
+#include "base/bind.h"
+#include "base/memory/scoped_ptr.h"
+#include "device/core/device_client.h"
+#include "device/usb/device_impl.h"
+#include "device/usb/public/cpp/device_manager_delegate.h"
+#include "device/usb/public/cpp/device_manager_factory.h"
+#include "device/usb/public/interfaces/device.mojom.h"
+#include "device/usb/type_converters.h"
+#include "device/usb/usb_device.h"
+#include "device/usb/usb_device_filter.h"
+#include "device/usb/usb_service.h"
+#include "third_party/mojo/src/mojo/public/cpp/bindings/array.h"
+#include "third_party/mojo/src/mojo/public/cpp/bindings/interface_request.h"
+
+namespace device {
+namespace usb {
+
+// static
+void DeviceManagerFactory::Build(mojo::InterfaceRequest<DeviceManager> request,
+                                 scoped_ptr<DeviceManagerDelegate> delegate) {
+  // Owned by its MessagePipe.
+  new DeviceManagerImpl(request.Pass(), delegate.Pass());
+}
+
+DeviceManagerImpl::DeviceManagerImpl(
+    mojo::InterfaceRequest<DeviceManager> request,
+    scoped_ptr<DeviceManagerDelegate> delegate)
+    : binding_(this, request.Pass()),
+      delegate_(delegate.Pass()),
+      weak_factory_(this) {
+  DCHECK(DeviceClient::Get());
+  usb_service_ = DeviceClient::Get()->GetUsbService();

[Reilly Grant (use Gerrit), 2015/05/27 21:00:52]

I would wait until GetDevices() is called to fetch the UsbService pointer.
Caching a raw pointer makes me nervous.

[Ken Rockot(use gerrit already), 2015/05/27 22:35:03]

Done.

+}
+
+DeviceManagerImpl::~DeviceManagerImpl() {
+}
+
+void DeviceManagerImpl::GetDevices(EnumerationOptionsPtr options,
+                                   const GetDevicesCallback& callback) {
+  if (!usb_service_) {
+    mojo::Array<EnumerationResultPtr> results(0);
+    callback.Run(results.Pass());
+    return;
+  }
+  std::vector<UsbDeviceFilter> filters =
+      options->filters.To<std::vector<UsbDeviceFilter>>();
+  usb_service_->GetDevices(base::Bind(&DeviceManagerImpl::OnGetDevices,
+                                      weak_factory_.GetWeakPtr(), callback,
+                                      filters));
+}
+
+void DeviceManagerImpl::OnGetDevices(
+    const GetDevicesCallback& callback,
+    const std::vector<UsbDeviceFilter>& filters,
+    const std::vector<scoped_refptr<UsbDevice>>& devices) {
+  mojo::Array<EnumerationResultPtr> results(0);
+  for (size_t i = 0; i < devices.size(); ++i) {
+    DeviceInfoPtr device_info = DeviceInfo::From(*devices[i]);
+    if (UsbDeviceFilter::MatchesAny(devices[i], filters) &&
+        delegate_->IsDeviceAllowed(*device_info)) {
+      EnumerationResultPtr result = EnumerationResult::New();
+      DevicePtr device;
+      // Owned by its message pipe.
+      new DeviceImpl(devices[i], mojo::GetProxy(&device));
+      result->device = device.Pass();
+      results.push_back(result.Pass());
+    }
+  }
+  callback.Run(results.Pass());
+}
+
+}  // namespace usb
+}  // namespace device