src/heap/heap.cc - Issue 1155163003: Don't shrink new space based on allocation rate in predictable mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap/heap.cc

Issue 1155163003: Don't shrink new space based on allocation rate in predictable mode. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/heap/heap.cc

diff --git a/src/heap/heap.cc b/src/heap/heap.cc

index 09f4cc71278e39c57be57099f4c08aedcef34cbd..7bf3c4bd3e153bdbe75194237888ddaf43b5edc6 100644

--- a/src/heap/heap.cc

+++ b/src/heap/heap.cc

@@ -4570,7 +4570,7 @@ bool Heap::HasLowAllocationRate(size_t allocation_rate) {

void Heap::ReduceNewSpaceSize(size_t allocation_rate) {

- if (HasLowAllocationRate(allocation_rate)) {

+ if (!FLAG_predictable && HasLowAllocationRate(allocation_rate)) {

new_space_.Shrink();

UncommitFromSpace();

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »