Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issue 115513004: Revert 240790 "roll gyp 1806:1816" (Closed)

Created:
7 years ago by scottmg
Modified:
7 years ago
Reviewers:
scottmg
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 240790 "roll gyp 1806:1816" 2.6 code fails. > roll gyp 1806:1816 > > r1807 win msvs: make ordering match .gyp order > r1808 Fix gyptest-app for Xcode 5.0.2 > r1809 Fix gyptest-xcode-gcc.py when using Xcode 5.0.2 > r1810 Fix gyptest-sdkroot when oldest SDK is >= 10.8 > r1811 Fix gyptest-xcode-env-order for Xcode 5.0.0 > r1812 win msvs: Make ordering of sources in subdir > r1813 win ninja: Refactor manifest generate and embed to be 1-pass > r1814 win ninja: default to embedding manifest to match msvs > r1815 Use gyp.common.EnsureDirExists in more places. > r1816 Add backported OrderedDict > > TBR=thakis@chromium.org > BUG=324863, 276953, 326030 > > Review URL: https://codereview.chromium.org/109223004 TBR=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=240793

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M trunk/src/DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
scottmg
7 years ago (2013-12-13 23:22:01 UTC) #1
scottmg
7 years ago (2013-12-13 23:22:08 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r240793.

Powered by Google App Engine
This is Rietveld 408576698