Issue 1155123007: README: integrate Android build instructions into "Build Mojo" section.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1155123007: README: integrate Android build instructions into "Build Mojo" section. (Closed)

Created:
5 years, 6 months ago by ppi

Modified:
5 years, 6 months ago

Reviewers:
tonyg

CC:
mojo-reviews_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

README: integrate Android build instructions into "Build Mojo" section. R=tonyg@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/87efd5f7e8bdda5007f78bab53d75249997cc707

Patch Set 2 : Address Tony's comments. #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -43 lines)			Patch
	M	README.md	View	1	5 chunks	+41 lines, -43 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

tonyg

lgtm https://codereview.chromium.org/1155123007/diff/1/README.md File README.md (right): https://codereview.chromium.org/1155123007/diff/1/README.md#newcode47 README.md:47: the file .gclient in your root Mojo directory ...

5 years, 6 months ago (2015-06-08 15:56:10 UTC) #3

ppi

Thanks! https://codereview.chromium.org/1155123007/diff/1/README.md File README.md (right): https://codereview.chromium.org/1155123007/diff/1/README.md#newcode47 README.md:47: the file .gclient in your root Mojo directory ...

5 years, 6 months ago (2015-06-08 16:00:30 UTC) #4

ppi

5 years, 6 months ago (2015-06-08 16:00:47 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
87efd5f7e8bdda5007f78bab53d75249997cc707 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 1155123007: README: integrate Android build instructions into "Build Mojo" section. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Address Tony's comments. #

Messages