Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 1155103004: [turbofan] New operator for loads of DYNAMIC_[GLOBAL,LOCAL]. (Closed)

Created:
5 years, 6 months ago by Michael Starzinger
Modified:
5 years, 6 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] New operator for loads of DYNAMIC_[GLOBAL,LOCAL]. This introduces two new operators for loads of variables bound to Variable::LOOKUP locations. Currently they all still lower to runtime calls, but will allow optimization during typed lowering. R=bmeurer@chromium.org Committed: https://crrev.com/861c427420f22a66890c6a64c1488d8a6c8cf42a Cr-Commit-Position: refs/heads/master@{#28713}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+327 lines, -44 lines) Patch
M src/compiler/ast-graph-builder.h View 3 chunks +19 lines, -12 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 16 chunks +80 lines, -32 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 1 chunk +23 lines, -0 lines 0 comments Download
M src/compiler/js-operator.h View 2 chunks +84 lines, -0 lines 0 comments Download
M src/compiler/js-operator.cc View 2 chunks +105 lines, -0 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/operator-properties.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Michael Starzinger
5 years, 6 months ago (2015-05-29 14:53:32 UTC) #1
Benedikt Meurer
LGTM with comment https://codereview.chromium.org/1155103004/diff/1/src/compiler/control-builders.h File src/compiler/control-builders.h (right): https://codereview.chromium.org/1155103004/diff/1/src/compiler/control-builders.h#newcode135 src/compiler/control-builders.h:135: void BreakUnless(Node* condition, BranchHint hint = ...
5 years, 6 months ago (2015-06-01 04:04:40 UTC) #2
Michael Starzinger
https://codereview.chromium.org/1155103004/diff/1/src/compiler/control-builders.h File src/compiler/control-builders.h (right): https://codereview.chromium.org/1155103004/diff/1/src/compiler/control-builders.h#newcode135 src/compiler/control-builders.h:135: void BreakUnless(Node* condition, BranchHint hint = BranchHint::kNone); On 2015/06/01 ...
5 years, 6 months ago (2015-06-01 07:12:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1155103004/20001
5 years, 6 months ago (2015-06-01 07:26:00 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-01 07:35:10 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-01 07:35:21 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/861c427420f22a66890c6a64c1488d8a6c8cf42a
Cr-Commit-Position: refs/heads/master@{#28713}

Powered by Google App Engine
This is Rietveld 408576698