Change multi-prerender API to include per launcher slots.

chrome/browser/prerender/prerender_link_manager.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PRERENDER_PRERENDER_LINK_MANAGER_H_
 #define CHROME_BROWSER_PRERENDER_PRERENDER_LINK_MANAGER_H_
 
-#include <map>
-#include <utility>
+#include <list>
 
 #include "base/basictypes.h"
 #include "chrome/browser/prerender/prerender_handle.h"
 #include "chrome/browser/profiles/profile_keyed_service.h"
 #include "googleurl/src/gurl.h"
 
 class Profile;
 
 namespace content {
 struct Referrer;
@@ skipping 14 matching lines @@
 // and controls the PrerenderManager accordingly.
 class PrerenderLinkManager : public ProfileKeyedService,
                              public PrerenderHandle::Observer {
  public:
   explicit PrerenderLinkManager(PrerenderManager* manager);
   virtual ~PrerenderLinkManager();
 
   // A <link rel=prerender ...> element has been inserted into the document.
   // The |prerender_id| must be unique per |child_id|, and is assigned by the
   // WebPrerendererClient.
-  // Returns true if the prerender was accepted by the prerender manager,
-  // and false if not.  In either case, the |prerender_id| is usable for
-  // future OnCancelPrerender and OnAbandonPrerender calls.
-  bool OnAddPrerender(
-      int child_id,
-      int prerender_id,
-      const GURL& url,
-      const content::Referrer& referrer,
-      const gfx::Size& size,
-      int render_view_route_id);
+  void OnAddPrerender(int child_id,
+                      int prerender_id,
+                      const GURL& url,
+                      const content::Referrer& referrer,
+                      const gfx::Size& size,
+                      int render_view_route_id);
 
   // A <link rel=prerender ...> element has been explicitly removed from a
   // document.
   void OnCancelPrerender(int child_id, int prerender_id);
 
   // A renderer launching <link rel=prerender ...> has navigated away from the
   // launching page, the launching renderer process has crashed, or perhaps the
   // renderer process was fast-closed when the last render view in it was
   // closed.
   void OnAbandonPrerender(int child_id, int prerender_id);
 
   // If a renderer channel closes (crash, fast exit, etc...), that's effectively
   // an abandon of any prerenders launched by that child.
   void OnChannelClosing(int child_id);
 
  private:
   friend class PrerenderBrowserTest;
   friend class PrerenderTest;
 
-  typedef std::pair<int, int> ChildAndPrerenderIdPair;
-  typedef std::map<ChildAndPrerenderIdPair, PrerenderHandle*>
-      IdPairToPrerenderHandleMap;
+  struct Prerender {
+    Prerender(int launcher_child_id,
+              int prerender_id,
+              const GURL& url,
+              const content::Referrer& referrer,
+              const gfx::Size& size,
+              int render_view_route_id);
+    ~Prerender();
 
-  void RemovePrerender(
-      const IdPairToPrerenderHandleMap::iterator& id_to_handle_iter);
+    // Parameters from PrerenderLinkManager::OnAddPrerender():
+    int launcher_child_id;
+    int prerender_id;
+    GURL url;
+    content::Referrer referrer;
+    gfx::Size size;
+    int render_view_route_id;
+
+    // Initially NULL, |handle| is set once we start this prerender. It is owned
+    // by this struct, and must be deleted before destructing this struct.
+    PrerenderHandle* handle;
+  };
 
   bool IsEmpty() const;
 
-  IdPairToPrerenderHandleMap::iterator FindPrerenderHandle(
-      PrerenderHandle* prerender_handle);
+  // Returns a count of currently running prerenders.
+  size_t CountRunningPrerenders() const;
+
+  // Start any prerenders that can be started, respecting concurrency limits for
+  // the system and per launcher.
+  void StartPrerenders();
+
+  Prerender* FindByLauncherChildIdAndPrerenderId(int child_id,
+                                                 int prerender_id);
+
+  Prerender* FindByPrerenderHandle(PrerenderHandle* prerender_handle);
+
+  void RemovePrerender(Prerender* prerender);
+
+  // From ProfileKeyedService:
+  virtual void Shutdown() OVERRIDE;
 
   // From PrerenderHandle::Observer:
   virtual void OnPrerenderStart(PrerenderHandle* prerender_handle) OVERRIDE;
   virtual void OnPrerenderStop(PrerenderHandle* prerender_handle) OVERRIDE;
   virtual void OnPrerenderAddAlias(PrerenderHandle* prerender_handle,
                                    const GURL& alias_url) OVERRIDE;
 
+  bool is_shutdown_;

[mmenke, 2012/12/18 17:15:15]

|has_shutdown_| may be clearer, since is_shutdown has two interpretations.  No
ambiguity if one thinks about it, but that requires thought.  Maybe my internal
lexical parser just needs an upgrade.

[gavinp, 2012/12/18 20:15:12]

Done.

+
   PrerenderManager* manager_;
 
-  // A map from child process id and prerender id to PrerenderHandles. We map
-  // from this pair because the prerender ids are only unique within their
-  // renderer process.
-  IdPairToPrerenderHandleMap ids_to_handle_map_;
+  // All prerenders known to this PrerenderLinkManager. Insertions are always
+  // made at the back, so the oldest prerender is at the front, and the youngest
+  // at the front.

[mmenke, 2012/12/18 17:15:15]

Youngest prerender is at the back.

[gavinp, 2012/12/18 20:15:12]

Ya, the other front.

Done.

+  std::list<Prerender> prerenders_;
 
   DISALLOW_COPY_AND_ASSIGN(PrerenderLinkManager);
 };
 
 }  // namespace prerender
 
 #endif  // CHROME_BROWSER_PRERENDER_PRERENDER_LINK_MANAGER_H_