Do not trigger primary color changes on non-supported toolbar states.

Do not trigger primary color changes on non-supported toolbar states.

This fixes an issue where you switch from the NTP to a normal tab
where it attempts to transition from transparent to gray on the
toolbar and results in a delayed update to the layout.

BUG=493082
Committed: https://crrev.com/a70b128369d6174464fab490e961b081fdd92560
Cr-Commit-Position: refs/heads/master@{#332240}

[Ted C, 2015-05-29 22:26:10]

tedchoc@chromium.org changed reviewers:
+ yusufo@chromium.org

[Ted C, 2015-05-29 22:26:10]

PTAL

[Yusuf, 2015-06-01 04:45:46]

https://codereview.chromium.org/1155053003/diff/1/chrome/android/java_staging...
File
chrome/android/java_staging/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java
(right):

https://codereview.chromium.org/1155053003/diff/1/chrome/android/java_staging...
chrome/android/java_staging/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java:1749:
} else if (mBrandColorTransitionAnimation != null
I thought we don't set the VISUAL STATE to brand color before the whole
animation has run(only the last call on AnimationFinished gets through the first
early return to set the visual state). To me this looks like it will always pass
the first if close and always end up cancelling the animation that is running
for theme colored sites.

Or I guess, if we are setting the state to brand color before/during animation,
where is it? :)

[Ted C, 2015-06-01 18:24:42]

https://codereview.chromium.org/1155053003/diff/1/chrome/android/java_staging...
File
chrome/android/java_staging/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java
(right):

https://codereview.chromium.org/1155053003/diff/1/chrome/android/java_staging...
chrome/android/java_staging/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java:1749:
} else if (mBrandColorTransitionAnimation != null
On 2015/06/01 04:45:46, Yusuf wrote:
> I thought we don't set the VISUAL STATE to brand color before the whole
> animation has run(only the last call on AnimationFinished gets through the
first
> early return to set the visual state). To me this looks like it will always
pass
> the first if close and always end up cancelling the animation that is running
> for theme colored sites.
> 
> Or I guess, if we are setting the state to brand color before/during
animation,
> where is it? :)

In the above block it checks whether the previous or next state is BRAND, so I
think it's covered here.

[Yusuf, 2015-06-01 18:27:55]

lgtm

[Ted C, 2015-06-01 18:47:12]

The CQ bit was checked by tedchoc@chromium.org

[commit-bot: I haz the power, 2015-06-01 18:51:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1155053003/20001

[commit-bot: I haz the power, 2015-06-01 19:30:27]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-06-01 19:31:44]

Patchset 2 (id:??) landed as
https://crrev.com/a70b128369d6174464fab490e961b081fdd92560
Cr-Commit-Position: refs/heads/master@{#332240}