Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 1155043004: Improve RenderNode performance (Closed)

Created:
5 years, 6 months ago by abarth-chromium
Modified:
5 years, 6 months ago
Reviewers:
eseidel
CC:
gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Improve RenderNode performance Experimenting with using the observatory profiler, I noticed two pieces of low-hanging performance fruit. This change removes about 4% of the total profile for layouting out and painting the flex demo. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/bf839051aceb4930b4f5f8c33688fd9b575dbffc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -8 lines) Patch
M sky/sdk/lib/framework/rendering/render_node.dart View 2 chunks +3 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
5 years, 6 months ago (2015-05-29 17:38:20 UTC) #1
eseidel
lgtm
5 years, 6 months ago (2015-05-29 17:41:30 UTC) #2
abarth-chromium
5 years, 6 months ago (2015-05-29 17:55:38 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
bf839051aceb4930b4f5f8c33688fd9b575dbffc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698