Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Issue 1155043002: Record send_start timing info after starting ServiceWorker (Closed)

Created:
5 years, 7 months ago by Kunihiko Sakamoto
Modified:
5 years, 7 months ago
Reviewers:
horo
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, kinuko+serviceworker, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Record send_start timing info after starting ServiceWorker The send_start field of LoadTimingInfo, which corresponds to the requestStart attribute of Resource Timing [1], was recorded before starting ServiceWorker. Since that point should be represented as the workerStart attribute [2], this patch moves send_start to DidPrepareFetchEvent, that is just before dispatching fetch event. [1] https://w3c.github.io/resource-timing/#widl-PerformanceResourceTiming-requestStart [2] https://w3c.github.io/resource-timing/#widl-PerformanceResourceTiming-workerStart BUG=465640 TEST=n/a Committed: https://crrev.com/a14b3794ee2e759cae74a48d8554fad69396577c Cr-Commit-Position: refs/heads/master@{#331271}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/browser/service_worker/service_worker_url_request_job.cc View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Kunihiko Sakamoto
ptal
5 years, 7 months ago (2015-05-25 08:04:37 UTC) #2
horo
lgtm
5 years, 7 months ago (2015-05-25 08:40:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1155043002/1
5 years, 7 months ago (2015-05-25 08:42:33 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-25 09:45:49 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-25 09:46:43 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a14b3794ee2e759cae74a48d8554fad69396577c
Cr-Commit-Position: refs/heads/master@{#331271}

Powered by Google App Engine
This is Rietveld 408576698