Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 115503003: remove SK_SUPPORT_LEGACY_PIXELREF_CONSTRUCTOR now that call-sites have been updated (Closed)

Created:
7 years ago by reed1
Modified:
6 years, 11 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

remove SK_SUPPORT_LEGACY_PIXELREF_CONSTRUCTOR now that call-sites have been updated BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242150

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : rebase #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M skia/ext/lazy_pixel_ref.cc View 1 2 3 4 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
reed1
7 years ago (2013-12-19 15:29:01 UTC) #1
reed1
7 years ago (2013-12-19 21:11:00 UTC) #2
scroggo
lgtm
7 years ago (2013-12-19 21:14:38 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years ago (2013-12-19 22:32:27 UTC) #4
reed1
looking for a committer/owner, who could also check the CQ
7 years ago (2013-12-19 22:35:54 UTC) #5
tomhudson
lgtm
7 years ago (2013-12-20 10:52:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reed@google.com/115503003/40001
7 years ago (2013-12-20 10:52:20 UTC) #7
commit-bot: I haz the power
Failed to apply patch for skia/skia_common.gypi: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years ago (2013-12-20 13:21:23 UTC) #8
robertphillips
This morning's DEPS roll also touched skia_common.gypi (https://codereview.chromium.org/107803003/) but it looks like git should've been ...
7 years ago (2013-12-20 13:23:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reed@google.com/115503003/80001
7 years ago (2013-12-20 16:55:17 UTC) #10
commit-bot: I haz the power
7 years ago (2013-12-20 19:49:42 UTC) #11
Message was sent while issue was closed.
Change committed as 242150

Powered by Google App Engine
This is Rietveld 408576698