Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 1155023002: Only notify the flowthread about style changes on actual descendants. (Closed)

Created:
5 years, 7 months ago by mstensho (USE GERRIT)
Modified:
5 years, 7 months ago
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Only notify the flowthread about style changes on actual descendants. Calling flowThreadContainingBlock() on the flow thread itself returns the flow thread, but the flow thread obviouly isn't a true descendant of itself, so let's avoid calling flowThreadDescendantStyleWillChange() and flowThreadDescendantStyleDidChange() then. There's currently no way any harm could be done if the flow tread were indeed treated as a descendant of itself here, but it's just wrong and bad. R=dsinclair@chromium.org,jchaffraix@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195863

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M Source/core/layout/LayoutObject.cpp View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
dsinclair
lgtm
5 years, 7 months ago (2015-05-25 13:45:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1155023002/1
5 years, 7 months ago (2015-05-25 13:45:20 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-05-25 13:47:42 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195863

Powered by Google App Engine
This is Rietveld 408576698