ui/base/accelerators/accelerator_manager_unittest.cc - Issue 1155013005: Refactoring the ownership of ui::InputMethod.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/base/accelerators/accelerator_manager_unittest.cc

Issue 1155013005: Refactoring the ownership of ui::InputMethod. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixed bot failure: cast_shell_linux Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/base/accelerators/accelerator_manager_unittest.cc

diff --git a/ui/base/accelerators/accelerator_manager_unittest.cc b/ui/base/accelerators/accelerator_manager_unittest.cc

index 1c3402d73e2b161fa4d018a5658424c451ad8b5a..1f8db027b139c0bfc3e3d251a6b0b4818ba049e0 100644

--- a/ui/base/accelerators/accelerator_manager_unittest.cc

+++ b/ui/base/accelerators/accelerator_manager_unittest.cc

@@ -151,12 +151,8 @@ TEST_F(AcceleratorManagerTest, Process) {

// The non-registered accelerators are not processed.

accelerator.set_type(ET_UNKNOWN);

EXPECT_FALSE(manager_.Process(accelerator)) << text; // different type

- accelerator.set_type(ET_TRANSLATED_KEY_PRESS);

- EXPECT_FALSE(manager_.Process(accelerator)) << text; // different type

accelerator.set_type(ET_KEY_RELEASED);

EXPECT_FALSE(manager_.Process(accelerator)) << text; // different type

- accelerator.set_type(ET_TRANSLATED_KEY_RELEASE);

- EXPECT_FALSE(manager_.Process(accelerator)) << text; // different type

EXPECT_FALSE(manager_.Process(GetAccelerator(VKEY_UNKNOWN, mask)))

<< text; // different vkey